All of lore.kernel.org
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Rami Rosen <ramirose@gmail.com>
Cc: linux-wireless@vger.kernel.org, reinette.chatre@intel.com
Subject: Re: [PATCH] [v2] iwlwifi: iwl-tx.c cleanup (remove unused parameters).
Date: Wed, 17 Dec 2008 11:39:08 -0500	[thread overview]
Message-ID: <20081217163908.GD12679@tuxdriver.com> (raw)
In-Reply-To: <eb3ff54b0812152335p6f768aa4r7ad68b33e62bd20b@mail.gmail.com>

On Tue, Dec 16, 2008 at 09:35:23AM +0200, Rami Rosen wrote:
> This patch removes unused parameters in methods in iwl-tx.c:
>=20
> - remove a parameter (is_unicast) from iwl_tx_cmd_build_basic()
> - remove a parameter (sta_id) from iwl_tx_cmd_build_rate()
> - remove two parameters (sta_id and priv) from iwl_tx_cmd_build_hwcry=
pto()

  CC [M]  drivers/net/wireless/iwlwifi/iwl-tx.o
drivers/net/wireless/iwlwifi/iwl-tx.c: In function =E2=80=98iwl_tx_cmd_=
build_hwcrypto=E2=80=99:
drivers/net/wireless/iwlwifi/iwl-tx.c:780: error: =E2=80=98priv=E2=80=99=
 undeclared (first use in this function)
drivers/net/wireless/iwlwifi/iwl-tx.c:780: error: (Each undeclared iden=
tifier is reported only once
drivers/net/wireless/iwlwifi/iwl-tx.c:780: error: for each function it =
appears in.)
make[2]: *** [drivers/net/wireless/iwlwifi/iwl-tx.o] Error 1

Did you compile w/ debugging enabled?

John
--=20
John W. Linville		Linux should be at the core
linville@tuxdriver.com			of your literate lifestyle.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2008-12-17 18:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-16  7:35 [PATCH] [v2] iwlwifi: iwl-tx.c cleanup (remove unused parameters) Rami Rosen
2008-12-17 16:39 ` John W. Linville [this message]
2008-12-17 21:51   ` [PATCH] [v3] " Rami Rosen
2008-12-17 22:42     ` Tomas Winkler
2008-12-18 15:31       ` John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081217163908.GD12679@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=ramirose@gmail.com \
    --cc=reinette.chatre@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.