From: "John W. Linville" <linville@tuxdriver.com>
To: Tomas Winkler <tomasw@gmail.com>
Cc: Rami Rosen <ramirose@gmail.com>,
linux-wireless@vger.kernel.org, reinette.chatre@intel.com
Subject: Re: [PATCH] [v3] iwlwifi: iwl-tx.c cleanup (remove unused parameters).
Date: Thu, 18 Dec 2008 10:31:49 -0500 [thread overview]
Message-ID: <20081218153149.GE4121@tuxdriver.com> (raw)
In-Reply-To: <1ba2fa240812171442i2a348e91paf3434d6b975642e@mail.gmail.com>
On Thu, Dec 18, 2008 at 12:42:37AM +0200, Tomas Winkler wrote:
> On Wed, Dec 17, 2008 at 11:51 PM, Rami Rosen <ramirose@gmail.com> wrote:
> > This patch removes unused parameters in methods in iwl-tx.c:
> > remove a parameter (is_unicast) from iwl_tx_cmd_build_basic()
> > remove a parameter (sta_id) from iwl_tx_cmd_build_rate()
> > remove a parameter (sta_id ) from iwl_tx_cmd_build_hwcrypto()
>
> Unicast can go sta_id has to stay, we need it for merging 3945 back
OK, I'll drop this patch and wait for a new submission.
John
--
John W. Linville Linux should be at the core
linville@tuxdriver.com of your literate lifestyle.
prev parent reply other threads:[~2008-12-18 15:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-16 7:35 [PATCH] [v2] iwlwifi: iwl-tx.c cleanup (remove unused parameters) Rami Rosen
2008-12-17 16:39 ` John W. Linville
2008-12-17 21:51 ` [PATCH] [v3] " Rami Rosen
2008-12-17 22:42 ` Tomas Winkler
2008-12-18 15:31 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081218153149.GE4121@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=linux-wireless@vger.kernel.org \
--cc=ramirose@gmail.com \
--cc=reinette.chatre@intel.com \
--cc=tomasw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.