From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: dri-devel@lists.sourceforge.net
Cc: Hannes Eder <hannes@hanneseder.net>,
David Airlie <airlied@linux.ie>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] drm/i915: add prototype for 'intelfb_panic' to header file
Date: Thu, 18 Dec 2008 23:40:07 +0000 [thread overview]
Message-ID: <200812181540.08366.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <494ad5e4.0baa660a.04de.7bb4@mx.google.com>
On Thursday, December 18, 2008 1:32 pm Hannes Eder wrote:
> Fix this sparse warning:
>
> drivers/gpu/drm/i915/intel_fb.c:417:5: warning: symbol 'intelfb_panic'
> was not declared. Should it be static?
Yep, this one should be static instead (I think, just double checking now to
make sure it's not used elsewhere, iirc it's not).
--
Jesse Barnes, Intel Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: dri-devel@lists.sourceforge.net
Cc: Hannes Eder <hannes@hanneseder.net>,
David Airlie <airlied@linux.ie>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] drm/i915: add prototype for 'intelfb_panic' to header file
Date: Thu, 18 Dec 2008 15:40:07 -0800 [thread overview]
Message-ID: <200812181540.08366.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <494ad5e4.0baa660a.04de.7bb4@mx.google.com>
On Thursday, December 18, 2008 1:32 pm Hannes Eder wrote:
> Fix this sparse warning:
>
> drivers/gpu/drm/i915/intel_fb.c:417:5: warning: symbol 'intelfb_panic'
> was not declared. Should it be static?
Yep, this one should be static instead (I think, just double checking now to
make sure it's not used elsewhere, iirc it's not).
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2008-12-18 23:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-18 21:32 [PATCH 6/6] drm/i915: add prototype for 'intelfb_panic' to header file Hannes Eder
2008-12-18 21:32 ` Hannes Eder
2008-12-18 23:40 ` Jesse Barnes [this message]
2008-12-18 23:40 ` Jesse Barnes
2008-12-19 11:34 ` [PATCH v2 6/6] drm/i915: un-EXPORT and make 'intelfb_panic' static Hannes Eder
2008-12-19 11:34 ` Hannes Eder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812181540.08366.jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.sourceforge.net \
--cc=hannes@hanneseder.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.