[PATCH] x86: process.c declare c1e_remove_cpu before they get used

[PATCH] x86: process.c declare c1e_remove_cpu before they get used

[Jaswinder Singh]

Impact: cleanup

Included asm/idle.h for c1e_remove_cpu declaration.

Signed-off-by: Jaswinder Singh <jaswinder@infradead.org>
---
 arch/x86/kernel/process.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
index f50f8bf..25313de 100644
--- a/arch/x86/kernel/process.c
+++ b/arch/x86/kernel/process.c
@@ -10,6 +10,7 @@
 #include <linux/ftrace.h>
 #include <asm/system.h>
 #include <asm/apic.h>
+#include <asm/idle.h>
 
 unsigned long idle_halt;
 EXPORT_SYMBOL(idle_halt);
-- 
1.5.5.1

Re: [PATCH] x86: process.c declare c1e_remove_cpu before they get used

[Ingo Molnar]

* Jaswinder Singh <jaswinder@infradead.org> wrote:

> Impact: cleanup
> 
> Included asm/idle.h for c1e_remove_cpu declaration.
> 
> Signed-off-by: Jaswinder Singh <jaswinder@infradead.org>
> ---
>  arch/x86/kernel/process.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
> index f50f8bf..25313de 100644
> --- a/arch/x86/kernel/process.c
> +++ b/arch/x86/kernel/process.c
> @@ -10,6 +10,7 @@
>  #include <linux/ftrace.h>
>  #include <asm/system.h>
>  #include <asm/apic.h>
> +#include <asm/idle.h>
>  
>  unsigned long idle_halt;
>  EXPORT_SYMBOL(idle_halt);

hm, why is this needed? Have you seen a compiler warning?

	Ingo

Re: [PATCH] x86: process.c declare c1e_remove_cpu before they get used

[Jaswinder Singh]

On Thu, 2008-12-18 at 13:36 +0100, Ingo Molnar wrote:

> hm, why is this needed? Have you seen a compiler warning?
> 

I was getting :

  CHECK   arch/x86/kernel/process.c
arch/x86/kernel/process.c:284:6: warning: symbol 'c1e_remove_cpu' was not declared. Should it be static?

Thank you,

Jaswinder Singh.

Re: [PATCH] x86: process.c declare c1e_remove_cpu before they get used

[Ingo Molnar]

* Jaswinder Singh <jaswinder@infradead.org> wrote:

> On Thu, 2008-12-18 at 13:36 +0100, Ingo Molnar wrote:
> 
> > hm, why is this needed? Have you seen a compiler warning?
> > 
> 
> I was getting :
> 
>   CHECK   arch/x86/kernel/process.c
> arch/x86/kernel/process.c:284:6: warning: symbol 'c1e_remove_cpu' was not declared. Should it be static?
> 
> Thank you,

ah, good. Feel free to include such information in future patches. I've 
applied your patch to tip/x86/cleanups, thanks! See below how the final 
commit looks like - added the sparse warning as well.

	Ingo

--------------->
>From f0bc2202e0373eb8e9b1ddbec930e2e681357db8 Mon Sep 17 00:00:00 2001
From: Jaswinder Singh <jaswinder@infradead.org>
Date: Wed, 17 Dec 2008 23:20:05 +0530
Subject: [PATCH] x86: process.c declare c1e_remove_cpu before they get used

Impact: cleanup, avoid sparse warning

Included asm/idle.h for c1e_remove_cpu() declaration. Fixes this
sparse warning:

  CHECK   arch/x86/kernel/process.c
  arch/x86/kernel/process.c:284:6: warning: symbol 'c1e_remove_cpu' was not declared. Should it be static?

Signed-off-by: Jaswinder Singh <jaswinder@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/kernel/process.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
index c622772..b06100f 100644
--- a/arch/x86/kernel/process.c
+++ b/arch/x86/kernel/process.c
@@ -1,6 +1,7 @@
 #include <linux/errno.h>
 #include <linux/kernel.h>
 #include <linux/mm.h>
+#include <asm/idle.h>
 #include <linux/smp.h>
 #include <linux/slab.h>
 #include <linux/sched.h>