From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Sukadev Bhattiprolu
<sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Cc: Linux Containers
<containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>,
lkml <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 2/2] ipc namespaces: implement support for posix msqueues
Date: Thu, 18 Dec 2008 15:36:33 -0600 [thread overview]
Message-ID: <20081218213633.GA20733@us.ibm.com> (raw)
In-Reply-To: <20081217212521.GA14740-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Quoting Sukadev Bhattiprolu (sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org):
> | static int mqueue_get_sb(struct file_system_type *fs_type,
> | int flags, const char *dev_name,
> | void *data, struct vfsmount *mnt)
> | {
> | - return get_sb_single(fs_type, flags, data, mqueue_fill_super, mnt);
> | + if (flags & MS_KERNMOUNT)
> | + return get_sb_single_ns(fs_type, flags, data,
> | + mqueue_fill_super, mnt);
> | + return get_sb_single_ns(fs_type, flags, current->nsproxy->ipc_ns,
> | + mqueue_fill_super, mnt);
>
> nit. This maybe easier to read with an ns local variable and a single
> call to get_sb_single_ns().
The first time I read this I completely misunderstood what you
meant. Yes, that's nicer. Thanks for taking a look.
New version coming tomorrow (I want to stress this a bit).
thanks,
-serge
WARNING: multiple messages have this Message-ID (diff)
From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Linux Containers <containers@lists.osdl.org>
Subject: Re: [PATCH 2/2] ipc namespaces: implement support for posix msqueues
Date: Thu, 18 Dec 2008 15:36:33 -0600 [thread overview]
Message-ID: <20081218213633.GA20733@us.ibm.com> (raw)
In-Reply-To: <20081217212521.GA14740@us.ibm.com>
Quoting Sukadev Bhattiprolu (sukadev@linux.vnet.ibm.com):
> | static int mqueue_get_sb(struct file_system_type *fs_type,
> | int flags, const char *dev_name,
> | void *data, struct vfsmount *mnt)
> | {
> | - return get_sb_single(fs_type, flags, data, mqueue_fill_super, mnt);
> | + if (flags & MS_KERNMOUNT)
> | + return get_sb_single_ns(fs_type, flags, data,
> | + mqueue_fill_super, mnt);
> | + return get_sb_single_ns(fs_type, flags, current->nsproxy->ipc_ns,
> | + mqueue_fill_super, mnt);
>
> nit. This maybe easier to read with an ns local variable and a single
> call to get_sb_single_ns().
The first time I read this I completely misunderstood what you
meant. Yes, that's nicer. Thanks for taking a look.
New version coming tomorrow (I want to stress this a bit).
thanks,
-serge
next prev parent reply other threads:[~2008-12-18 21:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-17 17:55 [RFC patch 0/2] posix mqueue namespace (v12) Serge E. Hallyn
2008-12-17 17:55 ` [PATCH 1/2] mqueue ns: move mqueue_mnt into struct ipc_namespace Serge E. Hallyn
2008-12-17 18:36 ` Dave Hansen
2008-12-17 18:52 ` Serge E. Hallyn
2008-12-17 18:55 ` Dave Hansen
2008-12-17 17:55 ` [PATCH 2/2] ipc namespaces: implement support for posix msqueues Serge E. Hallyn
2008-12-17 18:54 ` Dave Hansen
2008-12-17 19:08 ` Serge E. Hallyn
2008-12-17 19:08 ` Serge E. Hallyn
2008-12-17 21:25 ` Sukadev Bhattiprolu
[not found] ` <20081217212521.GA14740-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-12-18 21:36 ` Serge E. Hallyn [this message]
2008-12-18 21:36 ` Serge E. Hallyn
2008-12-17 17:57 ` [LTP PATCH 1/4] posix message queue namespaces: first test Serge E. Hallyn
2008-12-17 17:57 ` [LTP PATCH 2/4] posix mqns: test parent to child mq access Serge E. Hallyn
2008-12-17 17:58 ` [LTP PATCH 3/4] posix mqns: test vfs and mq interaction Serge E. Hallyn
2008-12-17 17:58 ` [LTP PATCH 4/4] posix mqns: test that user mount of posixmq survivies the ipcns Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081218213633.GA20733@us.ibm.com \
--to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.