All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: oleg@redhat.com, ebiederm@xmission.com, roland@redhat.com,
	bastian@waldi.eu.org
Cc: daniel@hozac.com, xemul@openvz.org, containers@lists.osdl.org,
	linux-kernel@vger.kernel.org
Subject: [RFC][PATCH 7/7][v4] SI_TKILL: Masquerade si_pid when crossing pid ns boundary
Date: Wed, 24 Dec 2008 03:53:31 -0800	[thread overview]
Message-ID: <20081224115331.GG8020@us.ibm.com> (raw)
In-Reply-To: <20081224114414.GA7879@us.ibm.com>


From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Subject: [RFC][PATCH 7/7][v4] SI_TKILL: Masquerade si_pid when crossing pid ns boundary

When sending a signal to a process in a descendant namespace, ->si_pid
must be set to the pid of sender in receiver's namespace. But if the
receiver is exiting (theoretically, ns == NULL), just set ->si_pid to
active pid namespace of sender (receiver won't see the signal anyway ?).

Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
---
 kernel/signal.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/kernel/signal.c b/kernel/signal.c
index 5a6aea8..e263c23 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -2385,17 +2385,22 @@ static int do_tkill(pid_t tgid, pid_t pid, int sig)
 	struct siginfo info;
 	struct task_struct *p;
 	unsigned long flags;
+	struct pid_namespace *ns;
 
 	error = -ESRCH;
 	info.si_signo = sig;
 	info.si_errno = 0;
 	info.si_code = SI_TKILL;
-	info.si_pid = task_tgid_vnr(current);
 	info.si_uid = current_uid();
 
 	rcu_read_lock();
 	p = find_task_by_vpid(pid);
 	if (p && (tgid <= 0 || task_tgid_vnr(p) == tgid)) {
+		ns = task_active_pid_ns(p);
+		if (ns)
+			info.si_pid = task_tgid_nr_ns(current, ns);
+		else
+			info.si_pid = task_tgid_vnr(current);
 		error = check_kill_permission(sig, &info, p);
 		/*
 		 * The null signal is a permissions and process existence
-- 
1.5.2.5

  parent reply	other threads:[~2008-12-24 11:53 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-24 11:44 [PATCH 0/7][v4] Container-init signal semantics Sukadev Bhattiprolu
2008-12-24 11:50 ` [RFC][PATCH 1/7][v4] Remove 'handler' parameter to tracehook functions Sukadev Bhattiprolu
2008-12-24 11:50 ` [RFC][PATCH 2/7][v4] Protect init from unwanted signals more Sukadev Bhattiprolu
     [not found]   ` <20081224115047.GB8020-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-12-24 16:35     ` Oleg Nesterov
2008-12-24 16:35       ` Oleg Nesterov
2008-12-24 21:11       ` Sukadev Bhattiprolu
2008-12-24 11:51 ` [RFC][PATCH 3/7][v4] Define siginfo_from_ancestor_ns() Sukadev Bhattiprolu
2008-12-24 16:28   ` Oleg Nesterov
     [not found]     ` <20081224162823.GE11593-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-12-24 21:24       ` Sukadev Bhattiprolu
2008-12-24 21:24         ` Sukadev Bhattiprolu
     [not found]         ` <20081224212426.GD13502-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-12-24 22:03           ` Oleg Nesterov
2008-12-24 22:03             ` Oleg Nesterov
2008-12-27 20:38             ` Sukadev Bhattiprolu
2008-12-24 11:51 ` [RFC][PATCH 4/7][v4] Protect cinit from unblocked SIG_DFL signals Sukadev Bhattiprolu
2008-12-24 11:52 ` [RFC][PATCH 5/7][v4] Protect cinit from blocked fatal signals Sukadev Bhattiprolu
2008-12-24 16:09   ` Oleg Nesterov
2008-12-24 21:25     ` Sukadev Bhattiprolu
2008-12-31  0:04     ` Roland McGrath
2009-01-05 12:24       ` Oleg Nesterov
2008-12-24 11:53 ` [RFC][PATCH 6/7][v4] SI_USER: Masquerade si_pid when crossing pid ns boundary Sukadev Bhattiprolu
2008-12-24 15:43   ` Oleg Nesterov
2008-12-24 16:18     ` Oleg Nesterov
2008-12-24 21:08     ` Sukadev Bhattiprolu
2008-12-24 11:53 ` Sukadev Bhattiprolu [this message]
2008-12-24 15:55   ` [RFC][PATCH 7/7][v4] SI_TKILL: " Oleg Nesterov
2008-12-24 21:04     ` Sukadev Bhattiprolu
2008-12-24 21:34       ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081224115331.GG8020@us.ibm.com \
    --to=sukadev@linux.vnet.ibm.com \
    --cc=bastian@waldi.eu.org \
    --cc=containers@lists.osdl.org \
    --cc=daniel@hozac.com \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=roland@redhat.com \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.