From: Oleg Nesterov <oleg@redhat.com>
To: Roland McGrath <roland@redhat.com>
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
ebiederm@xmission.com, bastian@waldi.eu.org, daniel@hozac.com,
xemul@openvz.org, containers@lists.osdl.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 5/7][v4] Protect cinit from blocked fatal signals
Date: Mon, 5 Jan 2009 13:24:23 +0100 [thread overview]
Message-ID: <20090105122423.GA3313@redhat.com> (raw)
In-Reply-To: <20081231000445.CEBC8FC278@magilla.sf.frob.com>
On 12/30, Roland McGrath wrote:
>
> > > + * If @signal refers to a container-init and @signr is neither SIGKILL nor
> > > + * SIGSTOP, it was queued because it was blocked when it was posted.
> >
> > This is not right too. It is possible that init had a handler when
> > the signal was sent, and the handler was set to SIG_DFL before the
> > signal was dequeued.
>
> do_sigaction's sig_handler_ignored() should exclude that.
Yes sure, but sig_handler_ignored(sig) can be false, it doesn't take
SIGNAL_UNKILLABLE into account.
Oleg.
next prev parent reply other threads:[~2009-01-05 12:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-24 11:44 [PATCH 0/7][v4] Container-init signal semantics Sukadev Bhattiprolu
2008-12-24 11:50 ` [RFC][PATCH 1/7][v4] Remove 'handler' parameter to tracehook functions Sukadev Bhattiprolu
2008-12-24 11:50 ` [RFC][PATCH 2/7][v4] Protect init from unwanted signals more Sukadev Bhattiprolu
[not found] ` <20081224115047.GB8020-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-12-24 16:35 ` Oleg Nesterov
2008-12-24 16:35 ` Oleg Nesterov
2008-12-24 21:11 ` Sukadev Bhattiprolu
2008-12-24 11:51 ` [RFC][PATCH 3/7][v4] Define siginfo_from_ancestor_ns() Sukadev Bhattiprolu
2008-12-24 16:28 ` Oleg Nesterov
[not found] ` <20081224162823.GE11593-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-12-24 21:24 ` Sukadev Bhattiprolu
2008-12-24 21:24 ` Sukadev Bhattiprolu
[not found] ` <20081224212426.GD13502-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-12-24 22:03 ` Oleg Nesterov
2008-12-24 22:03 ` Oleg Nesterov
2008-12-27 20:38 ` Sukadev Bhattiprolu
2008-12-24 11:51 ` [RFC][PATCH 4/7][v4] Protect cinit from unblocked SIG_DFL signals Sukadev Bhattiprolu
2008-12-24 11:52 ` [RFC][PATCH 5/7][v4] Protect cinit from blocked fatal signals Sukadev Bhattiprolu
2008-12-24 16:09 ` Oleg Nesterov
2008-12-24 21:25 ` Sukadev Bhattiprolu
2008-12-31 0:04 ` Roland McGrath
2009-01-05 12:24 ` Oleg Nesterov [this message]
2008-12-24 11:53 ` [RFC][PATCH 6/7][v4] SI_USER: Masquerade si_pid when crossing pid ns boundary Sukadev Bhattiprolu
2008-12-24 15:43 ` Oleg Nesterov
2008-12-24 16:18 ` Oleg Nesterov
2008-12-24 21:08 ` Sukadev Bhattiprolu
2008-12-24 11:53 ` [RFC][PATCH 7/7][v4] SI_TKILL: " Sukadev Bhattiprolu
2008-12-24 15:55 ` Oleg Nesterov
2008-12-24 21:04 ` Sukadev Bhattiprolu
2008-12-24 21:34 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090105122423.GA3313@redhat.com \
--to=oleg@redhat.com \
--cc=bastian@waldi.eu.org \
--cc=containers@lists.osdl.org \
--cc=daniel@hozac.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
--cc=sukadev@linux.vnet.ibm.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.