From: "Adeodato Simó" <dato@net.com.org.es>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] Add a commit.signoff configuration variable to always use --signoff.
Date: Sat, 27 Dec 2008 09:26:20 +0100 [thread overview]
Message-ID: <20081227082620.GA5230@chistera.yi.org> (raw)
In-Reply-To: <7vabaijvxl.fsf@gitster.siamese.dyndns.org>
* Junio C Hamano [Fri, 26 Dec 2008 16:36:38 -0800]:
> Adeodato Simó <dato@net.com.org.es> writes:
> > ... I'd
> > still like to hear if my patch would be suitable for inclusion, because
> > it's much more straightforward to use (and to discover).
> But "straightforward to discover" is not an advantage in this case.
> As long as it comes with documentation that clearly explains why this
> feature should not be used blindly in order to avoid diluting the value of
> S-o-b, I think the feature itself is not a harmful thing to have. Dscho's
> argument in the quoted thread that says it should be a conscious act to
> add S-o-b (except for the part he misunderstands what S-o-b attests), is a
> good one and still is valid.
Does this sound good? If so, I'll send an amended patch (or should I send an
incremental/extra one instead?):
+commit.signoff::
+ If set, 'git-commit' will always add a Signed-off-by line.
+ Please use this option with care: by enabling it, you're stating
+ that all your commits will invariably meet the S-o-b
+ requirements for any project you send patches to. It's probably
+ best to only use it from your private repositories' .git/config
+ file, and only for projects who require a S-o-b as proof of
+ provenance of the patch, and not of its correctness or quality.
> By the way, please do not deflect away responses meant to you by using a
> Mail-Followup-To header that points at the git mailing list. It is rude.
I set a M-F-T header because I prefer not to be CC'ed. I have other
mechanisms in place that prevent me from missing replies to my messages
(based on In-Reply-To/References headers).
Nevertheless, if the list normally operates CC-based, I can see how pressing
Reply-to-all and not seing the original autor in the recipient list can be
offputting, so I'll stop setting M-F-T in my messages to git@. (Hopefully
starting with this message already.)
I didn't mean for it to be rude in any way.
Thanks,
--
Adeodato Simó dato at net.com.org.es
Debian Developer adeodato at debian.org
A conference is a gathering of important people who singly can do nothing
but together can decide that nothing can be done.
-- Fred Allen
next prev parent reply other threads:[~2008-12-27 8:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-26 12:56 [PATCH] Add a commit.signoff configuration variable to always use --signoff Adeodato Simó
2008-12-26 22:02 ` Nanako Shiraishi
2008-12-26 22:10 ` Adeodato Simó
2008-12-27 0:36 ` Junio C Hamano
2008-12-27 8:26 ` Adeodato Simó [this message]
2008-12-27 8:44 ` Junio C Hamano
2008-12-27 9:03 ` Adeodato Simó
2008-12-27 11:04 ` Thomas Rast
2008-12-27 11:05 ` Adeodato Simó
2008-12-27 11:53 ` Junio C Hamano
2008-12-27 12:01 ` Adeodato Simó
2008-12-29 11:16 ` [PATCH v3] Add a commit.signoff configuration option to always use --signoff in commit Adeodato Simó
2008-12-29 11:18 ` Adeodato Simó
2008-12-30 21:04 ` Junio C Hamano
2009-01-01 22:18 ` Adeodato Simó
2009-01-02 12:46 ` Adeodato Simó
2008-12-27 18:08 ` [PATCH] Add a commit.signoff configuration variable to always use --signoff Jan Krüger
2008-12-27 18:40 ` Adeodato Simó
2008-12-27 19:15 ` Jan Krüger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081227082620.GA5230@chistera.yi.org \
--to=dato@net.com.org.es \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.