All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Krüger" <jk@jk.gs>
To: "Adeodato Simó" <dato@net.com.org.es>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Add a commit.signoff configuration variable to always use --signoff.
Date: Sat, 27 Dec 2008 19:08:19 +0100	[thread overview]
Message-ID: <20081227190819.7257932a@neuron> (raw)
In-Reply-To: <1230296219-16408-1-git-send-email-dato@net.com.org.es>

Hi,

On Fri, 26 Dec 2008 13:56:59 +0100
"Adeodato Simó" <dato@net.com.org.es> wrote:

> > Has there even been talk of a commit.signoff configuration variable
> > to always add a S-o-b line? This could allow to enable it on a
> > per-project basis, which would be cool.
> 
> Well, it seemed easy enough to do, so I went ahead. Comments would be
> welcome.

I think it might be a good idea to allow overriding the config variable
in the other direction, i.e. a --no-signoff option to commit. Otherwise,
for example, rebase would have no way of suppressing the S-o-b lines in
rebased commits (and you might want to not automatically sign off
commits you rebase).

-Jan

  parent reply	other threads:[~2008-12-27 18:10 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-26 12:56 [PATCH] Add a commit.signoff configuration variable to always use --signoff Adeodato Simó
2008-12-26 22:02 ` Nanako Shiraishi
2008-12-26 22:10   ` Adeodato Simó
2008-12-27  0:36     ` Junio C Hamano
2008-12-27  8:26       ` Adeodato Simó
2008-12-27  8:44         ` Junio C Hamano
2008-12-27  9:03           ` Adeodato Simó
2008-12-27 11:04             ` Thomas Rast
2008-12-27 11:05               ` Adeodato Simó
2008-12-27 11:53             ` Junio C Hamano
2008-12-27 12:01               ` Adeodato Simó
2008-12-29 11:16                 ` [PATCH v3] Add a commit.signoff configuration option to always use --signoff in commit Adeodato Simó
2008-12-29 11:18                   ` Adeodato Simó
2008-12-30 21:04                   ` Junio C Hamano
2009-01-01 22:18                     ` Adeodato Simó
2009-01-02 12:46                       ` Adeodato Simó
2008-12-27 18:08 ` Jan Krüger [this message]
2008-12-27 18:40   ` [PATCH] Add a commit.signoff configuration variable to always use --signoff Adeodato Simó
2008-12-27 19:15     ` Jan Krüger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081227190819.7257932a@neuron \
    --to=jk@jk.gs \
    --cc=dato@net.com.org.es \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.