From: Sarah Sharp <sarah.a.sharp@intel.com>
To: Julia Lawall <julia@diku.dk>
Cc: gregkh@suse.de, dbrownell@users.sourceforge.net,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] include/linux: Move definitions from usb.h to usb/ch9.h
Date: Tue, 30 Dec 2008 23:39:00 +0000 [thread overview]
Message-ID: <20081230233727.GA12819@gamba.jf.intel.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0812292247300.2265@ask.diku.dk>
On Mon, Dec 29, 2008 at 10:48:19PM +0100, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> The functions:
>
> usb_endpoint_dir_in(epd)
> usb_endpoint_dir_out(epd)
> usb_endpoint_is_bulk_in(epd)
> usb_endpoint_is_bulk_out(epd)
> usb_endpoint_is_int_in(epd)
> usb_endpoint_is_int_out(epd)
> usb_endpoint_is_isoc_in(epd)
> usb_endpoint_is_isoc_out(epd)
> usb_endpoint_num(epd)
> usb_endpoint_type(epd)
> usb_endpoint_xfer_bulk(epd)
> usb_endpoint_xfer_control(epd)
> usb_endpoint_xfer_int(epd)
> usb_endpoint_xfer_isoc(epd)
>
> are moved from include/linux/usb.h to include/linux/usb/ch9.h.
> include/linux/usb/ch9.h makes more sense for these functions because they
> only depend on constants that are defined in this file.
I thought the include/linux/usb/ch9.h was supposed to include values that are
defined in various USB specifications (starting with the protocol "chapter 9"
from the USB 1.1 bus specification). The constants (masks) used by these
functions aren't part of the standards, so why move these functions to
include/linux/usb/ch9.h? Was it confusing to find these functions, or do you
have an overall plan for these changes?
Sarah Sharp
WARNING: multiple messages have this Message-ID (diff)
From: Sarah Sharp <sarah.a.sharp@intel.com>
To: Julia Lawall <julia@diku.dk>
Cc: gregkh@suse.de, dbrownell@users.sourceforge.net,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] include/linux: Move definitions from usb.h to usb/ch9.h
Date: Tue, 30 Dec 2008 15:39:00 -0800 [thread overview]
Message-ID: <20081230233727.GA12819@gamba.jf.intel.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0812292247300.2265@ask.diku.dk>
On Mon, Dec 29, 2008 at 10:48:19PM +0100, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> The functions:
>
> usb_endpoint_dir_in(epd)
> usb_endpoint_dir_out(epd)
> usb_endpoint_is_bulk_in(epd)
> usb_endpoint_is_bulk_out(epd)
> usb_endpoint_is_int_in(epd)
> usb_endpoint_is_int_out(epd)
> usb_endpoint_is_isoc_in(epd)
> usb_endpoint_is_isoc_out(epd)
> usb_endpoint_num(epd)
> usb_endpoint_type(epd)
> usb_endpoint_xfer_bulk(epd)
> usb_endpoint_xfer_control(epd)
> usb_endpoint_xfer_int(epd)
> usb_endpoint_xfer_isoc(epd)
>
> are moved from include/linux/usb.h to include/linux/usb/ch9.h.
> include/linux/usb/ch9.h makes more sense for these functions because they
> only depend on constants that are defined in this file.
I thought the include/linux/usb/ch9.h was supposed to include values that are
defined in various USB specifications (starting with the protocol "chapter 9"
from the USB 1.1 bus specification). The constants (masks) used by these
functions aren't part of the standards, so why move these functions to
include/linux/usb/ch9.h? Was it confusing to find these functions, or do you
have an overall plan for these changes?
Sarah Sharp
next prev parent reply other threads:[~2008-12-30 23:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 21:48 [PATCH] include/linux: Move definitions from usb.h to usb/ch9.h Julia Lawall
2008-12-29 21:48 ` Julia Lawall
2008-12-30 0:25 ` David Brownell
2008-12-30 0:25 ` David Brownell
2008-12-30 23:39 ` Sarah Sharp [this message]
2008-12-30 23:39 ` Sarah Sharp
2008-12-31 1:40 ` David Brownell
2008-12-31 1:40 ` David Brownell
2009-01-02 2:01 ` Sarah Sharp
2009-01-02 2:01 ` Sarah Sharp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081230233727.GA12819@gamba.jf.intel.com \
--to=sarah.a.sharp@intel.com \
--cc=dbrownell@users.sourceforge.net \
--cc=gregkh@suse.de \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.