From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Zhang Rui <rui.zhang@intel.com>
Cc: Richard Purdie <rpurdie@rpsys.net>,
linux-acpi <linux-acpi@vger.kernel.org>,
Len Brown <lenb@kernel.org>
Subject: Re: [PATCH 1/2] video: always update the brightness when poking "brightness"
Date: Wed, 31 Dec 2008 02:01:46 +0000 [thread overview]
Message-ID: <20081231020146.GA24861@srcf.ucam.org> (raw)
In-Reply-To: <1230687781.562.249.camel@rzhang-dt>
On Wed, Dec 31, 2008 at 09:43:01AM +0800, Zhang Rui wrote:
> then how about this case:
> 1. set the brightness level to 5 via sysfs I/F
> 2. set the backlight to another level via HOTKEYS.
> 3. setting it back to 5 doesn't work because bd->props.brightness
> is still 5.
If they're using the ACPI interface then video.c should update
props.brightness itself.
> IMO, the real problem is that bd->props.brightness doesn't reflect the
> actual brightness.
If you want the actual brightness, why aren't you reading
actual_brightness?
--
Matthew Garrett | mjg59@srcf.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-12-31 2:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-24 3:07 [PATCH 1/2] video: always update the brightness when poking "brightness" Zhang Rui
2008-12-30 10:34 ` Richard Purdie
2008-12-31 1:22 ` Zhao Yakui
2008-12-31 1:21 ` Matthew Garrett
2008-12-31 1:43 ` Zhang Rui
2008-12-31 2:01 ` Matthew Garrett [this message]
2008-12-31 2:58 ` Zhang Rui
2008-12-31 3:11 ` Zhang Rui
2008-12-31 3:24 ` Matthew Garrett
2008-12-31 3:14 ` Matthew Garrett
2008-12-31 13:41 ` Matthew Garrett
2008-12-31 14:16 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081231020146.GA24861@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.