From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Zhang Rui <rui.zhang@intel.com>
Cc: Richard Purdie <rpurdie@rpsys.net>,
linux-acpi <linux-acpi@vger.kernel.org>,
Len Brown <lenb@kernel.org>
Subject: Re: [PATCH 1/2] video: always update the brightness when poking "brightness"
Date: Wed, 31 Dec 2008 03:24:12 +0000 [thread overview]
Message-ID: <20081231032412.GA25598@srcf.ucam.org> (raw)
In-Reply-To: <1230693119.562.300.camel@rzhang-dt>
On Wed, Dec 31, 2008 at 11:11:59AM +0800, Zhang Rui wrote:
> On Wed, 2008-12-31 at 10:58 +0800, Zhang Rui wrote:
> > always update pros.brightness no matter the backlight is changed
> > via procfs, hotkeys or sysfs.
> by the way, with this patch applied, we really don't need
> "actual_brightness" any more, at least for ACPI backlight class I/F.
> is there any chance that "actual_brightness" returns a different value
> from "brightness"?
Depending on _DOS, AC events can switch the backlight value without
sending a notification. I don't /think/ it's worth worrying about that
case, but it's still worth keeping the two attributes so that there's a
consistent interface for userspace.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2008-12-31 3:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-24 3:07 [PATCH 1/2] video: always update the brightness when poking "brightness" Zhang Rui
2008-12-30 10:34 ` Richard Purdie
2008-12-31 1:22 ` Zhao Yakui
2008-12-31 1:21 ` Matthew Garrett
2008-12-31 1:43 ` Zhang Rui
2008-12-31 2:01 ` Matthew Garrett
2008-12-31 2:58 ` Zhang Rui
2008-12-31 3:11 ` Zhang Rui
2008-12-31 3:24 ` Matthew Garrett [this message]
2008-12-31 3:14 ` Matthew Garrett
2008-12-31 13:41 ` Matthew Garrett
2008-12-31 14:16 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081231032412.GA25598@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.