From: Christoph Hellwig <hch@infradead.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux Kernel Development <linux-kernel@vger.kernel.org>,
xfs@oss.sgi.com, Christoph Hellwig <hch@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [GIT PULL] XFS update for 2.6.29
Date: Thu, 1 Jan 2009 12:03:29 -0500 [thread overview]
Message-ID: <20090101170329.GA17892@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0901011048090.14380@anakin>
On Thu, Jan 01, 2009 at 10:50:52AM +0100, Geert Uytterhoeven wrote:
> | fs/xfs/xfs_btree.c: In function 'xfs_btree_readahead_lblock':
> | fs/xfs/xfs_btree.c:736: warning: comparison is always true due to limited range of data type
> | fs/xfs/xfs_btree.c:741: warning: comparison is always true due to limited range of data type
>
> left/right = xfs_fsblock_t (32 or 64 bit), NULLDFSBNO = xfs_dfsbno_t (64 bit)
Hmm, can't reproduce it here with CONFIG_LBD=n on x86, but the following
patch should fix it:
Index: linux-2.6/fs/xfs/xfs_btree.c
===================================================================
--- linux-2.6.orig/fs/xfs/xfs_btree.c 2009-01-01 15:57:04.606547140 +0100
+++ linux-2.6/fs/xfs/xfs_btree.c 2009-01-01 15:57:24.780673454 +0100
@@ -730,8 +730,8 @@ xfs_btree_readahead_lblock(
struct xfs_btree_block *block)
{
int rval = 0;
- xfs_fsblock_t left = be64_to_cpu(block->bb_u.l.bb_leftsib);
- xfs_fsblock_t right = be64_to_cpu(block->bb_u.l.bb_rightsib);
+ xfs_dfsbno_t left = be64_to_cpu(block->bb_u.l.bb_leftsib);
+ xfs_dfsbno_t right = be64_to_cpu(block->bb_u.l.bb_rightsib);
if ((lr & XFS_BTCUR_LEFTRA) && left != NULLDFSBNO) {
xfs_btree_reada_bufl(cur->bc_mp, left, 1);
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Lachlan McIlroy <lachlan@sgi.com>,
Christoph Hellwig <hch@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
xfs@oss.sgi.com, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [GIT PULL] XFS update for 2.6.29
Date: Thu, 1 Jan 2009 12:03:29 -0500 [thread overview]
Message-ID: <20090101170329.GA17892@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0901011048090.14380@anakin>
On Thu, Jan 01, 2009 at 10:50:52AM +0100, Geert Uytterhoeven wrote:
> | fs/xfs/xfs_btree.c: In function 'xfs_btree_readahead_lblock':
> | fs/xfs/xfs_btree.c:736: warning: comparison is always true due to limited range of data type
> | fs/xfs/xfs_btree.c:741: warning: comparison is always true due to limited range of data type
>
> left/right = xfs_fsblock_t (32 or 64 bit), NULLDFSBNO = xfs_dfsbno_t (64 bit)
Hmm, can't reproduce it here with CONFIG_LBD=n on x86, but the following
patch should fix it:
Index: linux-2.6/fs/xfs/xfs_btree.c
===================================================================
--- linux-2.6.orig/fs/xfs/xfs_btree.c 2009-01-01 15:57:04.606547140 +0100
+++ linux-2.6/fs/xfs/xfs_btree.c 2009-01-01 15:57:24.780673454 +0100
@@ -730,8 +730,8 @@ xfs_btree_readahead_lblock(
struct xfs_btree_block *block)
{
int rval = 0;
- xfs_fsblock_t left = be64_to_cpu(block->bb_u.l.bb_leftsib);
- xfs_fsblock_t right = be64_to_cpu(block->bb_u.l.bb_rightsib);
+ xfs_dfsbno_t left = be64_to_cpu(block->bb_u.l.bb_leftsib);
+ xfs_dfsbno_t right = be64_to_cpu(block->bb_u.l.bb_rightsib);
if ((lr & XFS_BTCUR_LEFTRA) && left != NULLDFSBNO) {
xfs_btree_reada_bufl(cur->bc_mp, left, 1);
next prev parent reply other threads:[~2009-01-01 17:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-30 3:08 [GIT PULL] XFS update for 2.6.29 Lachlan McIlroy
2008-12-30 3:08 ` Lachlan McIlroy
2008-12-31 1:39 ` Linus Torvalds
2008-12-31 1:39 ` Linus Torvalds
2008-12-31 1:45 ` Lachlan McIlroy
2008-12-31 1:45 ` Lachlan McIlroy
2008-12-31 1:50 ` Linus Torvalds
2008-12-31 1:50 ` Linus Torvalds
2008-12-31 1:58 ` Lachlan McIlroy
2008-12-31 1:58 ` Lachlan McIlroy
2009-01-01 9:50 ` Geert Uytterhoeven
2009-01-01 9:50 ` Geert Uytterhoeven
2009-01-01 17:03 ` Christoph Hellwig [this message]
2009-01-01 17:03 ` Christoph Hellwig
2009-01-02 9:57 ` Geert Uytterhoeven
2009-01-02 9:57 ` Geert Uytterhoeven
2009-01-02 9:58 ` Christoph Hellwig
2009-01-02 9:58 ` Christoph Hellwig
2009-01-11 10:38 ` Geert Uytterhoeven
2009-01-11 10:38 ` Geert Uytterhoeven
2009-01-11 15:45 ` Christoph Hellwig
2009-01-11 15:45 ` Christoph Hellwig
[not found] ` <200812311419.10199.nickpiggin@yahoo.com.au>
2009-01-05 3:27 ` Lachlan McIlroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090101170329.GA17892@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.