scripts/checkpatch.pl in 2.4 git

scripts/checkpatch.pl in 2.4 git

[Jaswinder Singh Rajput]

Hello Willy,

Do you have any plans to add scripts/checkpatch.pl in 2.4 git.

Currently, what is the procedure to check patch for 2.4 git.

Thank you,
JSR

Re: scripts/checkpatch.pl in 2.4 git

[Willy Tarreau]

On Sat, Jan 03, 2009 at 07:04:57PM +0530, Jaswinder Singh Rajput wrote:
> Hello Willy,
> 
> Do you have any plans to add scripts/checkpatch.pl in 2.4 git.

Not particularly planned, though I have nothing against including it if
some people want to use it.

> Currently, what is the procedure to check patch for 2.4 git.

Nowadays, 2.4 patches are so small that one's eyes are enough to check
for correctness ;-)

And sometimes if the patch is not correct, I do fix it myself while merging it.

Regards,
Willy

Re: scripts/checkpatch.pl in 2.4 git

[Jaswinder Singh Rajput]

On Sat, Jan 3, 2009 at 7:15 PM, Willy Tarreau <w@1wt.eu> wrote:
> On Sat, Jan 03, 2009 at 07:04:57PM +0530, Jaswinder Singh Rajput wrote:
>> Hello Willy,
>>
>> Do you have any plans to add scripts/checkpatch.pl in 2.4 git.
>
> Not particularly planned, though I have nothing against including it if
> some people want to use it.
>

Please add it. At least I can use it :-)

>> Currently, what is the procedure to check patch for 2.4 git.
>
> Nowadays, 2.4 patches are so small that one's eyes are enough to check
> for correctness ;-)
>

I ran 2.6 checkpatch.pl on some files and found lot of style problems
like white spaces and indent.
After fixing these problems code will be more read-able.
I have plan to fix these problems on some important files. What you
think about this.

Thank you,
JSR

Re: scripts/checkpatch.pl in 2.4 git

[Willy Tarreau]

On Sat, Jan 03, 2009 at 07:54:34PM +0530, Jaswinder Singh Rajput wrote:
> On Sat, Jan 3, 2009 at 7:15 PM, Willy Tarreau <w@1wt.eu> wrote:
> > On Sat, Jan 03, 2009 at 07:04:57PM +0530, Jaswinder Singh Rajput wrote:
> >> Hello Willy,
> >>
> >> Do you have any plans to add scripts/checkpatch.pl in 2.4 git.
> >
> > Not particularly planned, though I have nothing against including it if
> > some people want to use it.
> >
> 
> Please add it. At least I can use it :-)

OK will do.

> >> Currently, what is the procedure to check patch for 2.4 git.
> >
> > Nowadays, 2.4 patches are so small that one's eyes are enough to check
> > for correctness ;-)
> >
> 
> I ran 2.6 checkpatch.pl on some files and found lot of style problems
> like white spaces and indent.
> After fixing these problems code will be more read-able.
> I have plan to fix these problems on some important files. What you
> think about this.

I don't want to merge pure code cleanup patches, because :
  1) it brings no added value to the final user
  2) there's always a risk of regression

The only exception I accept to make is when I resync a file with 2.6 in
order to ease future patches.

However, I welcome cleanups which come with other changes/fixes, provided
they're not too invasive.

Regards,
Willy