From: Andi Kleen <andi@firstfloor.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linville@tuxdriver.com, davem <davem@davemloft.net>
Subject: Re: [PATCH] Fix up truesize after pskb_expand_head() in wireless stack
Date: Sun, 4 Jan 2009 18:43:39 +0100 [thread overview]
Message-ID: <20090104174339.GX496@one.firstfloor.org> (raw)
In-Reply-To: <1231087288.3296.15.camel@johannes>
On Sun, Jan 04, 2009 at 05:41:28PM +0100, Johannes Berg wrote:
> On Sun, 2009-01-04 at 17:28 +0100, Andi Kleen wrote:
> > > Thanks, but I'll need to look at this in more detail, we need to make
> > > sure that we orphan the skb before
> >
> > What do you mean with orphaning the skb?
>
> Well, touching truesize is absolutely not allowed while the skb is
> charged to a socket. This is what causes the truesize warning. The thing
The cause of the warnings was because the skb changed, but
truesize didn't.
> we need to do is figure out is why the skb has a wrong truesize.
Because it was expanded without truesize being adjusted (see my
original mail)
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi-Vw/NltI1exuRpAAqCnN02g@public.gmane.org>
To: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
Cc: Andi Kleen <andi-Vw/NltI1exuRpAAqCnN02g@public.gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org,
davem <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Subject: Re: [PATCH] Fix up truesize after pskb_expand_head() in wireless stack
Date: Sun, 4 Jan 2009 18:43:39 +0100 [thread overview]
Message-ID: <20090104174339.GX496@one.firstfloor.org> (raw)
In-Reply-To: <1231087288.3296.15.camel@johannes>
On Sun, Jan 04, 2009 at 05:41:28PM +0100, Johannes Berg wrote:
> On Sun, 2009-01-04 at 17:28 +0100, Andi Kleen wrote:
> > > Thanks, but I'll need to look at this in more detail, we need to make
> > > sure that we orphan the skb before
> >
> > What do you mean with orphaning the skb?
>
> Well, touching truesize is absolutely not allowed while the skb is
> charged to a socket. This is what causes the truesize warning. The thing
The cause of the warnings was because the skb changed, but
truesize didn't.
> we need to do is figure out is why the skb has a wrong truesize.
Because it was expanded without truesize being adjusted (see my
original mail)
-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-01-04 17:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-04 15:18 [PATCH] Fix up truesize after pskb_expand_head() in wireless stack Andi Kleen
2009-01-04 15:18 ` Andi Kleen
2009-01-04 16:05 ` Johannes Berg
2009-01-04 16:05 ` Johannes Berg
2009-01-04 16:28 ` Andi Kleen
2009-01-04 16:28 ` Andi Kleen
2009-01-04 16:41 ` Johannes Berg
2009-01-04 16:41 ` Johannes Berg
2009-01-04 17:43 ` Andi Kleen [this message]
2009-01-04 17:43 ` Andi Kleen
2009-01-04 17:33 ` Johannes Berg
2009-01-04 17:33 ` Johannes Berg
2009-01-04 18:41 ` Andi Kleen
2009-01-05 6:49 ` David Miller
2009-01-05 13:32 ` Andi Kleen
2009-01-05 8:36 ` Johannes Berg
2009-01-05 13:21 ` Andi Kleen
2009-01-05 13:16 ` Johannes Berg
2009-01-05 13:16 ` Johannes Berg
2009-01-05 13:36 ` Andi Kleen
2009-01-05 13:31 ` Johannes Berg
2009-01-05 14:05 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090104174339.GX496@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.