From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: aluno <aluno3@poczta.onet.pl>, xfs@oss.sgi.com
Subject: Re: xfs_db problem
Date: Wed, 7 Jan 2009 12:46:09 -0500 [thread overview]
Message-ID: <20090107174609.GA8915@infradead.org> (raw)
In-Reply-To: <4964BF7E.6060906@sandeen.net>
On Wed, Jan 07, 2009 at 08:43:10AM -0600, Eric Sandeen wrote:
> The thing is, xfs_db could in theory be used to *fix* the bad magic
> number, so refusing to continue might be a problem. But perhaps when
> invoked as xfs_admin, it should just bail out. It would be interesting
> to find where the actual failure is, though...
We have bugzilla open for this, too. I think it's reasonable to
get a warning, but not the additional problems when calling xfs_db
directly because that's a low-level tool for people that know what
they do.
But when called through wrappers like xfs_admin we should first do
the magic number check. I think the proper way to implement this
is to add an option to xfs_db to perform the magic number check,
and make sure all the wrapper scripts set it, similar to how they
already use -p <progname>.
Any volunteer to implement this? It should be fairly simple.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-01-07 17:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 14:34 xfs_db problem aluno
2009-01-07 14:43 ` Eric Sandeen
2009-01-07 17:46 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-01-07 14:37 aluno3
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090107174609.GA8915@infradead.org \
--to=hch@infradead.org \
--cc=aluno3@poczta.onet.pl \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.