From: Arnd Bergmann <arnd@arndb.de>
To: Geoff Levand <geoffrey.levand@am.sony.com>
Cc: David Woodhouse <David.Woodhouse@intel.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Jim Paris <jim@jtan.com>,
linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org,
Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
Vivien Chappelier <vivien.chappelier@free.fr>,
cbe-oss-dev@ozlabs.org
Subject: Re: [patch 0/6] ps3vram driver patches
Date: Wed, 7 Jan 2009 19:44:44 +0100 [thread overview]
Message-ID: <200901071944.45680.arnd@arndb.de> (raw)
In-Reply-To: <4963CDCA.4080802@am.sony.com>
On Tuesday 06 January 2009, Geoff Levand wrote:
> Patches 3-6 are minor cleanups suggested by Arnd Bergmann. I have left two
> of Arnd's sugestions, implementing the driver as a block device, similar to
> the axonram driver, and eliminating the need to ioremap. These will require
> a significant re-work.
My complaint about the ioremap was just about the type of the mapping,
not something fundamental. Please just replace ioremap(addr, size) with
ioremap_flags(addr, size, _PAGE_NO_CACHE) in order to get a mapping without
the guarded bit.
If everyone else thinks that doing the ps3vram driver as an MTD rather than
a block device is acceptable, I have no further objections. Thanks for
following up on my other comments.
Acked-by: Arnd Bergmann <arnd@arndb.de>
Arnd <><
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Geoff Levand <geoffrey.levand@am.sony.com>
Cc: David Woodhouse <David.Woodhouse@intel.com>,
Jim Paris <jim@jtan.com>,
linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org,
Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
Vivien Chappelier <vivien.chappelier@free.fr>,
cbe-oss-dev@ozlabs.org
Subject: Re: [patch 0/6] ps3vram driver patches
Date: Wed, 7 Jan 2009 19:44:44 +0100 [thread overview]
Message-ID: <200901071944.45680.arnd@arndb.de> (raw)
In-Reply-To: <4963CDCA.4080802@am.sony.com>
On Tuesday 06 January 2009, Geoff Levand wrote:
> Patches 3-6 are minor cleanups suggested by Arnd Bergmann. =A0I have left=
two
> of Arnd's sugestions, implementing the driver as a block device, similar =
to
> the axonram driver, and eliminating the need to ioremap. =A0These will re=
quire
> a significant re-work.
My complaint about the ioremap was just about the type of the mapping,
not something fundamental. Please just replace ioremap(addr, size) with
ioremap_flags(addr, size, _PAGE_NO_CACHE) in order to get a mapping without
the guarded bit.
If everyone else thinks that doing the ps3vram driver as an MTD rather than
a block device is acceptable, I have no further objections. Thanks for
following up on my other comments.
Acked-by: Arnd Bergmann <arnd@arndb.de>
Arnd <><
next prev parent reply other threads:[~2009-01-07 18:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-06 21:31 [patch 0/6] ps3vram driver patches Geoff Levand
2009-01-07 18:44 ` Arnd Bergmann [this message]
2009-01-07 18:44 ` Arnd Bergmann
2009-01-07 19:23 ` Geoff Levand
2009-01-07 19:23 ` Geoff Levand
2009-01-07 19:53 ` Arnd Bergmann
2009-01-07 19:53 ` Arnd Bergmann
2009-01-08 10:34 ` Geert Uytterhoeven
2009-01-08 10:34 ` Geert Uytterhoeven
2009-01-08 1:22 ` [patch] mtd/ps3vram: Use _PAGE_NO_CACHE in memory ioremap Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901071944.45680.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=David.Woodhouse@intel.com \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=benh@kernel.crashing.org \
--cc=cbe-oss-dev@ozlabs.org \
--cc=geoffrey.levand@am.sony.com \
--cc=jim@jtan.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=vivien.chappelier@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.