* [PATCH] wimax: fix compile bug
@ 2009-01-08 16:12 Heiko Carstens
2009-01-08 16:52 ` Greg KH
2009-01-08 17:03 ` Marcel Holtmann
0 siblings, 2 replies; 7+ messages in thread
From: Heiko Carstens @ 2009-01-08 16:12 UTC (permalink / raw)
To: Linus Torvalds, Inaky Perez-Gonzalez, Greg Kroah-Hartman
Cc: Martin Schwidefsky, linux-kernel
From: Heiko Carstens <heiko.carstens@de.ibm.com>
wimax should depend on INPUT:
net/built-in.o: In function `wimax_rfkill_rm':
linux-2.6/net/wimax/op-rfkill.c:428: undefined reference to `input_unregister_device'
net/built-in.o: In function `wimax_rfkill_add':
linux-2.6/net/wimax/op-rfkill.c:370: undefined reference to `input_allocate_device'
linux-2.6/net/wimax/op-rfkill.c:384: undefined reference to `input_register_device'
linux-2.6/net/wimax/op-rfkill.c:402: undefined reference to `input_unregister_device'
linux-2.6/net/wimax/op-rfkill.c:406: undefined reference to `input_free_device'
net/built-in.o: In function `input_report_key':
linux-2.6/include/linux/input.h:1285: undefined reference to `input_event'
Cc: Inaky Perez-Gonzalez <inaky@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
net/wimax/Kconfig | 1 +
1 file changed, 1 insertion(+)
Index: linux-2.6/net/wimax/Kconfig
===================================================================
--- linux-2.6.orig/net/wimax/Kconfig
+++ linux-2.6/net/wimax/Kconfig
@@ -4,6 +4,7 @@
menuconfig WIMAX
tristate "WiMAX Wireless Broadband support"
+ depends on INPUT
help
Select to configure support for devices that provide
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] wimax: fix compile bug
2009-01-08 16:12 [PATCH] wimax: fix compile bug Heiko Carstens
@ 2009-01-08 16:52 ` Greg KH
2009-01-08 16:58 ` David Miller
2009-01-08 17:03 ` Marcel Holtmann
1 sibling, 1 reply; 7+ messages in thread
From: Greg KH @ 2009-01-08 16:52 UTC (permalink / raw)
To: Heiko Carstens
Cc: Linus Torvalds, Inaky Perez-Gonzalez, Martin Schwidefsky,
linux-kernel
On Thu, Jan 08, 2009 at 05:12:22PM +0100, Heiko Carstens wrote:
> From: Heiko Carstens <heiko.carstens@de.ibm.com>
>
> wimax should depend on INPUT:
<snip>
Inaky just sent a series of 3 patches to the netdev mailing list fixing
this up in a much better way.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] wimax: fix compile bug
2009-01-08 16:52 ` Greg KH
@ 2009-01-08 16:58 ` David Miller
2009-01-08 17:01 ` Heiko Carstens
2009-01-08 18:11 ` Inaky Perez-Gonzalez
0 siblings, 2 replies; 7+ messages in thread
From: David Miller @ 2009-01-08 16:58 UTC (permalink / raw)
To: gregkh; +Cc: heiko.carstens, torvalds, inaky, schwidefsky, linux-kernel
From: Greg KH <gregkh@suse.de>
Date: Thu, 8 Jan 2009 08:52:54 -0800
> On Thu, Jan 08, 2009 at 05:12:22PM +0100, Heiko Carstens wrote:
> > From: Heiko Carstens <heiko.carstens@de.ibm.com>
> >
> > wimax should depend on INPUT:
>
> <snip>
>
> Inaky just sent a series of 3 patches to the netdev mailing list fixing
> this up in a much better way.
Yep, I'll be integrating his patches during the course of
today.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] wimax: fix compile bug
2009-01-08 16:58 ` David Miller
@ 2009-01-08 17:01 ` Heiko Carstens
2009-01-08 18:11 ` Inaky Perez-Gonzalez
1 sibling, 0 replies; 7+ messages in thread
From: Heiko Carstens @ 2009-01-08 17:01 UTC (permalink / raw)
To: David Miller; +Cc: gregkh, torvalds, inaky, schwidefsky, linux-kernel
On Thu, Jan 08, 2009 at 08:58:06AM -0800, David Miller wrote:
> From: Greg KH <gregkh@suse.de>
> Date: Thu, 8 Jan 2009 08:52:54 -0800
>
> > On Thu, Jan 08, 2009 at 05:12:22PM +0100, Heiko Carstens wrote:
> > > From: Heiko Carstens <heiko.carstens@de.ibm.com>
> > >
> > > wimax should depend on INPUT:
> >
> > <snip>
> >
> > Inaky just sent a series of 3 patches to the netdev mailing list fixing
> > this up in a much better way.
>
> Yep, I'll be integrating his patches during the course of
> today.
Even better. Thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] wimax: fix compile bug
2009-01-08 16:12 [PATCH] wimax: fix compile bug Heiko Carstens
2009-01-08 16:52 ` Greg KH
@ 2009-01-08 17:03 ` Marcel Holtmann
1 sibling, 0 replies; 7+ messages in thread
From: Marcel Holtmann @ 2009-01-08 17:03 UTC (permalink / raw)
To: Heiko Carstens
Cc: Linus Torvalds, Inaky Perez-Gonzalez, Greg Kroah-Hartman,
Martin Schwidefsky, linux-kernel
Hi Heiko,
> wimax should depend on INPUT:
>
> net/built-in.o: In function `wimax_rfkill_rm':
> linux-2.6/net/wimax/op-rfkill.c:428: undefined reference to `input_unregister_device'
> net/built-in.o: In function `wimax_rfkill_add':
> linux-2.6/net/wimax/op-rfkill.c:370: undefined reference to `input_allocate_device'
> linux-2.6/net/wimax/op-rfkill.c:384: undefined reference to `input_register_device'
> linux-2.6/net/wimax/op-rfkill.c:402: undefined reference to `input_unregister_device'
> linux-2.6/net/wimax/op-rfkill.c:406: undefined reference to `input_free_device'
> net/built-in.o: In function `input_report_key':
> linux-2.6/include/linux/input.h:1285: undefined reference to `input_event'
>
> Cc: Inaky Perez-Gonzalez <inaky@linux.intel.com>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
actually Inaky posted a different fix for this to netdev yesterday.
Regards
Marcel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] wimax: fix compile bug
2009-01-08 16:58 ` David Miller
2009-01-08 17:01 ` Heiko Carstens
@ 2009-01-08 18:11 ` Inaky Perez-Gonzalez
2009-01-08 18:36 ` David Miller
1 sibling, 1 reply; 7+ messages in thread
From: Inaky Perez-Gonzalez @ 2009-01-08 18:11 UTC (permalink / raw)
To: David Miller; +Cc: gregkh, heiko.carstens, torvalds, schwidefsky, linux-kernel
On Thursday 08 January 2009, David Miller wrote:
> From: Greg KH <gregkh@suse.de>
> Date: Thu, 8 Jan 2009 08:52:54 -0800
>
> > On Thu, Jan 08, 2009 at 05:12:22PM +0100, Heiko Carstens wrote:
> > > From: Heiko Carstens <heiko.carstens@de.ibm.com>
> > >
> > > wimax should depend on INPUT:
> >
> > <snip>
> >
> > Inaky just sent a series of 3 patches to the netdev mailing list fixing
> > this up in a much better way.
>
> Yep, I'll be integrating his patches during the course of
> today.
Thanks David
Please be sure to integrate v3 of the patchset
(http://lkml.org/lkml/2009/1/7/397), shows as the 1/4 series
in patchwork.ozlabs.org.
--
Inaky
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] wimax: fix compile bug
2009-01-08 18:11 ` Inaky Perez-Gonzalez
@ 2009-01-08 18:36 ` David Miller
0 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2009-01-08 18:36 UTC (permalink / raw)
To: inaky; +Cc: gregkh, heiko.carstens, torvalds, schwidefsky, linux-kernel
From: Inaky Perez-Gonzalez <inaky@linux.intel.com>
Date: Thu, 8 Jan 2009 10:11:56 -0800
> Please be sure to integrate v3 of the patchset
> (http://lkml.org/lkml/2009/1/7/397), shows as the 1/4 series
> in patchwork.ozlabs.org.
Right.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2009-01-08 18:36 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-08 16:12 [PATCH] wimax: fix compile bug Heiko Carstens
2009-01-08 16:52 ` Greg KH
2009-01-08 16:58 ` David Miller
2009-01-08 17:01 ` Heiko Carstens
2009-01-08 18:11 ` Inaky Perez-Gonzalez
2009-01-08 18:36 ` David Miller
2009-01-08 17:03 ` Marcel Holtmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.