All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Trolle Selander <trolle.selander@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH] [RFC] Variable video ram size option
Date: Fri, 9 Jan 2009 16:02:21 -0800	[thread overview]
Message-ID: <200901091702.22432.paul@codesourcery.com> (raw)
In-Reply-To: <4967A96B.3020902@eu.citrix.com>

On Friday 09 January 2009 12:45:47 Trolle Selander wrote:
> +#ifdef TARGET_SPARC
> +    vga_ram_size += (1024 * 1024);
> +#endif

This looks pretty bogus.

> +    if ( vga_ram_size > 16*1024*1024 )
> +    {
> +        fprintf(stderr,"The stdvga/VBE device model currently has no use
> for more than 16 Megs of vram. Video ram reduced to 16M. \n"); +       
> vga_ram_size = 16*1024*1024;

I'm pretty sure this is wrong. VBE alows arbritary sized virtual framebuffers.

Paul

  reply	other threads:[~2009-01-10  0:02 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-09 19:45 [Qemu-devel] [PATCH] [RFC] Variable video ram size option Trolle Selander
2009-01-10  0:02 ` Paul Brook [this message]
2009-01-10  1:26   ` Trolle Selander
2009-01-10  6:45     ` Blue Swirl
     [not found]   ` <4967E7D7.4040605@eu.citrix.com>
     [not found]     ` <200901091716.00827.paul@codesourcery.com>
2009-01-10  1:27       ` Trolle Selander
     [not found]       ` <4967ECA7.6040809@eu.citrix.com>
     [not found]         ` <200901091747.06462.paul@codesourcery.com>
2009-01-10  1:28           ` Trolle Selander
2009-01-10  1:47             ` Jamie Lokier
2009-01-11  7:53 ` Avi Kivity
2009-01-12 17:43   ` Trolle Selander
2009-01-21 18:07   ` [Qemu-devel] [PATCH] [RFC] Variable video ram size option - revised Trolle Selander
2009-01-21 18:23     ` Daniel P. Berrange
2009-01-21 21:51       ` Anthony Liguori
2009-01-21 21:21     ` [Qemu-devel] " Trolle Selander
  -- strict thread matches above, loose matches on Subject: below --
2009-01-12 19:13 [Qemu-devel] [PATCH] [RFC] Variable video ram size option Trolle Selander
2009-01-14 20:07 ` Paul Brook
2009-01-14 20:41   ` Trolle Selander
2009-01-14 21:30     ` Paul Brook
2009-01-14 22:47       ` Trolle Selander
2009-01-15 13:08         ` Jamie Lokier
2009-01-15 15:37           ` Rene Rebe
2009-01-15 16:23             ` Jamie Lokier
2009-01-15 17:36               ` Gerd Hoffmann
2009-01-15 20:57                 ` Jamie Lokier
2009-01-15 21:41                   ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200901091702.22432.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    --cc=trolle.selander@eu.citrix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.