Re: [Qemu-devel] [PATCH] [RFC] Variable video ram size option - revised

[Anthony Liguori <anthony@codemonkey.ws>]

Daniel P. Berrange wrote:
> On Wed, Jan 21, 2009 at 01:07:51PM -0500, Trolle Selander wrote:
>   
>> Hi all,
>>
>> This is an updated version of the patch after the suggestions/discussion 
>> on the list. It also includes different handling of how the -vga option 
>> is handled internally, replacing the multiple 
>> independent-yet-mutually-exclusive xxx_vga_enabled variables with one 
>> vgahw_model variable, and also includes the -vga none option added by 
>> Stefano in the time since my last version of this patch. Further 
>> comments & testing welcome. :)
>>     
>
>
>
>   
>> @@ -4933,6 +4930,13 @@
>>              case QEMU_OPTION_vga:
>>                  select_vgahw (optarg);
>>                  break;
>> +            case QEMU_OPTION_videoram:
>> +                {
>> +                    char *ptr;
>> +                    vga_ram_size = strtol(optarg,&ptr,10);
>> +                    vga_ram_size *= 1024 * 1024;
>> +                }
>> +                break;
>>              case QEMU_OPTION_g:
>>                  {
>>                      const char *p;
>>     
>
> Rather than adding more add hoc extra parameters for VGA tunables, we 
> should just make -vga work like the other generic device args, accepting
> a optional list comma separated values following it
>
> eg 
>
>   -vga cirrus,ram=32
>   

Agreed.

Regards,

Anthony Liguori

> Regards,
> Daniel
>