From: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
To: Clifford Wolf <clifford-cPpHkPqGOEfk7+2FdBfRIA@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org,
khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org,
adrian-nKrwMtk+6Wm9FHfhHBbuYA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
Subject: Re: [PATCH] Incremental i2c-mpc driver fix for multi-master i2c busses.
Date: Mon, 12 Jan 2009 14:12:00 -0800 [thread overview]
Message-ID: <20090112141200.ca89caab.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090105132102.GA27855-cPpHkPqGOEfk7+2FdBfRIA@public.gmane.org>
On Mon, 5 Jan 2009 14:21:02 +0100
Clifford Wolf <clifford-cPpHkPqGOEfk7+2FdBfRIA@public.gmane.org> wrote:
> Incremental i2c-mpc driver fix for multi-master i2c busses.
>
> This is an incremental bugfix for the i2c-mpc driver. It is based
> on the bugfix I've sent on 2008-12-22:
>
> http://lkml.org/lkml/2008/12/22/99
>
> There still was a remaining problem with multi-master i2c busses
> when an i2c bus access is interrupted by a unix signal while
> waiting for bus arbitration.
>
> This is an extreamly rare case but I managed to stumble over it in
> multi master i2c performance tests.
>
> Tested with a freescale MPC8349E host cpu.
That's not a very good changelog - it has basically no information,
apart from the linked-to original changelog.
And the linked-to changelog has no description of the bug which is
being fixed.
> --- drivers/i2c/busses/i2c-mpc.c (revision 2216)
> +++ drivers/i2c/busses/i2c-mpc.c (working copy)
Please prepare patches in `patch -p1' form:
--- a/drivers/i2c/busses/i2c-mpc.c
+++ a/drivers/i2c/busses/i2c-mpc.c
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Clifford Wolf <clifford@clifford.at>
Cc: linux-kernel@vger.kernel.org, i2c@lm-sensors.org,
khali@linux-fr.org, adrian@humboldt.co.uk,
linux-i2c@vger.kernel.org, Ben Dooks <ben-linux@fluff.org>
Subject: Re: [PATCH] Incremental i2c-mpc driver fix for multi-master i2c busses.
Date: Mon, 12 Jan 2009 14:12:00 -0800 [thread overview]
Message-ID: <20090112141200.ca89caab.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090105132102.GA27855@clifford.at>
On Mon, 5 Jan 2009 14:21:02 +0100
Clifford Wolf <clifford@clifford.at> wrote:
> Incremental i2c-mpc driver fix for multi-master i2c busses.
>
> This is an incremental bugfix for the i2c-mpc driver. It is based
> on the bugfix I've sent on 2008-12-22:
>
> http://lkml.org/lkml/2008/12/22/99
>
> There still was a remaining problem with multi-master i2c busses
> when an i2c bus access is interrupted by a unix signal while
> waiting for bus arbitration.
>
> This is an extreamly rare case but I managed to stumble over it in
> multi master i2c performance tests.
>
> Tested with a freescale MPC8349E host cpu.
That's not a very good changelog - it has basically no information,
apart from the linked-to original changelog.
And the linked-to changelog has no description of the bug which is
being fixed.
> --- drivers/i2c/busses/i2c-mpc.c (revision 2216)
> +++ drivers/i2c/busses/i2c-mpc.c (working copy)
Please prepare patches in `patch -p1' form:
--- a/drivers/i2c/busses/i2c-mpc.c
+++ a/drivers/i2c/busses/i2c-mpc.c
next prev parent reply other threads:[~2009-01-12 22:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-05 13:21 [PATCH] Incremental i2c-mpc driver fix for multi-master i2c busses Clifford Wolf
2009-01-06 10:23 ` Ben Dooks
[not found] ` <20090105132102.GA27855-cPpHkPqGOEfk7+2FdBfRIA@public.gmane.org>
2009-01-12 22:12 ` Andrew Morton [this message]
2009-01-12 22:12 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090112141200.ca89caab.akpm@linux-foundation.org \
--to=akpm-de/tnxtf+jlsfhdxvbkv3wd2fqjk+8+b@public.gmane.org \
--cc=adrian-nKrwMtk+6Wm9FHfhHBbuYA@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=clifford-cPpHkPqGOEfk7+2FdBfRIA@public.gmane.org \
--cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.