From: Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>
To: Jeff Chua <jeff.chua.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Linus Torvalds
<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Christian Borntraeger
<borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>,
Daniel Drake <dsd-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>,
"Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Kernel Testers List
<kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Phil Dibowitz <phil-LijsOF1cAEA@public.gmane.org>
Subject: Re: [Bug #12422] 2.6.28-git can't resume from str
Date: Tue, 13 Jan 2009 02:28:00 +0100 [thread overview]
Message-ID: <20090113012800.GA15492@elte.hu> (raw)
In-Reply-To: <b6a2187b0901121720s1f9b12ednb76a90dcc7eddc81-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
* Jeff Chua <jeff.chua.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On Mon, Jan 12, 2009 at 2:07 AM, Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org> wrote:
> >> Everything in-between should have
> >> a0e280e0f33f6c859a235fb69a875ed8f3420388 applied?
> > not necessarily - if an intermediate tree that is checked happened to have
> > been based on some earlier -rc, it might have that bug included. Safest is
> > to always cherry-pick that commit. (if it has no dependencies)
>
> Thanks for pointing this out. My bisect was thrown off course because
> I didn't "cherry-pick" that commit.
>
> After cherry picking, I ended up with the same commit as was reported by
> Christian Borntraeger -- "Regression 2.6.28-git: suspend/resume
> failure. git bisected to usb suspend/resume patch".
>
> I was trying to bisect further, but ended up with this strange behavior...
>
> # start with a "fresh linux git download".
> # ls
> . .. .git .gitignore .mailmap COPYING
> CREDITS Documentation Kbuild MAINTAINERS Makefile README
> REPORTING-BUGS arch block crypto drivers firmware
> fs include init ipc kernel lib
> mm net samples scripts security sound
> usr virt
>
> # git bisect bad ae04d1401577bb63151480a053057de58b8e10bb
> # git bisect good a3a798c88a14b35e5d4ca30716dbc9eb9a1ddfe2
> Bisecting: 579 revisions left to test after this
> [079899c2384023cd8efcd3806680b4f1d2abbd54] Btrfs: Change
> find_extent_buffer to use TestSetPageLocked
>
> # ls
> . .. .git fs
>
> Is this a bug or a feature?
that's a feature - the btrfs history looks like this. You can mark get out
of that bisection set by doing this:
git bisect good 34353029534a08e41cfb8be647d734b9ce9ebff8
Ingo
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: Jeff Chua <jeff.chua.linux@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Daniel Drake <dsd@gentoo.org>, "Rafael J. Wysocki" <rjw@sisk.pl>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kernel Testers List <kernel-testers@vger.kernel.org>,
Phil Dibowitz <phil@ipom.com>
Subject: Re: [Bug #12422] 2.6.28-git can't resume from str
Date: Tue, 13 Jan 2009 02:28:00 +0100 [thread overview]
Message-ID: <20090113012800.GA15492@elte.hu> (raw)
In-Reply-To: <b6a2187b0901121720s1f9b12ednb76a90dcc7eddc81@mail.gmail.com>
* Jeff Chua <jeff.chua.linux@gmail.com> wrote:
> On Mon, Jan 12, 2009 at 2:07 AM, Ingo Molnar <mingo@elte.hu> wrote:
> >> Everything in-between should have
> >> a0e280e0f33f6c859a235fb69a875ed8f3420388 applied?
> > not necessarily - if an intermediate tree that is checked happened to have
> > been based on some earlier -rc, it might have that bug included. Safest is
> > to always cherry-pick that commit. (if it has no dependencies)
>
> Thanks for pointing this out. My bisect was thrown off course because
> I didn't "cherry-pick" that commit.
>
> After cherry picking, I ended up with the same commit as was reported by
> Christian Borntraeger -- "Regression 2.6.28-git: suspend/resume
> failure. git bisected to usb suspend/resume patch".
>
> I was trying to bisect further, but ended up with this strange behavior...
>
> # start with a "fresh linux git download".
> # ls
> . .. .git .gitignore .mailmap COPYING
> CREDITS Documentation Kbuild MAINTAINERS Makefile README
> REPORTING-BUGS arch block crypto drivers firmware
> fs include init ipc kernel lib
> mm net samples scripts security sound
> usr virt
>
> # git bisect bad ae04d1401577bb63151480a053057de58b8e10bb
> # git bisect good a3a798c88a14b35e5d4ca30716dbc9eb9a1ddfe2
> Bisecting: 579 revisions left to test after this
> [079899c2384023cd8efcd3806680b4f1d2abbd54] Btrfs: Change
> find_extent_buffer to use TestSetPageLocked
>
> # ls
> . .. .git fs
>
> Is this a bug or a feature?
that's a feature - the btrfs history looks like this. You can mark get out
of that bisection set by doing this:
git bisect good 34353029534a08e41cfb8be647d734b9ce9ebff8
Ingo
next prev parent reply other threads:[~2009-01-13 1:28 UTC|newest]
Thread overview: 111+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-11 11:12 2.6.29-rc1: Reported regressions from 2.6.28 Rafael J. Wysocki
2009-01-11 11:12 ` [Bug #12399] USB wakeup problem on Toshiba Portege R500 Rafael J. Wysocki
2009-01-11 11:12 ` Rafael J. Wysocki
2009-01-11 21:14 ` Maxim Levitsky
2009-01-11 21:14 ` Maxim Levitsky
2009-01-11 11:16 ` [Bug #12414] iwl4965 cannot use "ap auto" on latest 2.6.28/29? Rafael J. Wysocki
2009-01-11 11:16 ` Rafael J. Wysocki
2009-01-11 13:57 ` Jeff Chua
2009-01-11 13:57 ` Jeff Chua
[not found] ` <b6a2187b0901110557xb696d03n9a7c7acad122e561-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-01-11 18:55 ` Rafael J. Wysocki
2009-01-11 18:55 ` Rafael J. Wysocki
2009-01-11 11:16 ` [Bug #12402] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 Rafael J. Wysocki
2009-01-11 11:16 ` Rafael J. Wysocki
2009-01-11 11:16 ` [Bug #12415] WARNING: at drivers/net/wireless/iwlwifi/iwl-sta.c:689 Rafael J. Wysocki
2009-01-11 11:16 ` Rafael J. Wysocki
2009-01-12 11:15 ` Christian Borntraeger
2009-01-12 11:15 ` Christian Borntraeger
[not found] ` <200901121215.31749.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2009-01-12 12:47 ` Rafael J. Wysocki
2009-01-12 12:47 ` Rafael J. Wysocki
[not found] ` <200901121347.42799.rjw-KKrjLPT3xs0@public.gmane.org>
2009-01-18 15:49 ` Christian Borntraeger
2009-01-18 15:49 ` Christian Borntraeger
2009-01-11 11:16 ` [Bug #12416] Recent change to kernel spikes out ccache/distcc Rafael J. Wysocki
2009-01-11 11:16 ` Rafael J. Wysocki
2009-01-11 11:16 ` [Bug #12400] git-latest: kernel oops in IOMMU setup Rafael J. Wysocki
2009-01-11 11:16 ` Rafael J. Wysocki
2009-01-11 11:16 ` [Bug #12417] glx performance drop with: "x86: PAT: implement track/untrack of pfnmap regions for x86 - v3" Rafael J. Wysocki
2009-01-11 11:16 ` Rafael J. Wysocki
2009-01-14 7:38 ` Alexey Fisher
2009-01-14 7:38 ` Alexey Fisher
[not found] ` <496D968C.4050405-M18mAb7Tlt0yCq4wW13eYl6hYfS7NtTn@public.gmane.org>
2009-01-14 7:51 ` Pallipadi, Venkatesh
2009-01-14 7:51 ` Pallipadi, Venkatesh
2009-01-11 11:16 ` [Bug #12418] Repeated ioctl(4, 0x40046445, ..) loop in glxgears Rafael J. Wysocki
2009-01-11 11:16 ` Rafael J. Wysocki
2009-01-11 11:16 ` [Bug #12422] 2.6.28-git can't resume from str Rafael J. Wysocki
2009-01-11 11:16 ` Rafael J. Wysocki
2009-01-11 13:57 ` Jeff Chua
2009-01-11 13:57 ` Jeff Chua
2009-01-11 14:08 ` Daniel Drake
[not found] ` <4969FD64.8040408-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2009-01-11 14:18 ` Christian Borntraeger
2009-01-11 14:18 ` Christian Borntraeger
[not found] ` <200901111518.38880.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2009-01-11 16:13 ` Jeff Chua
2009-01-11 16:13 ` Jeff Chua
[not found] ` <b6a2187b0901110813s5429573cm7d78f39e288f70a3-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-01-11 16:18 ` Christian Borntraeger
2009-01-11 16:18 ` Christian Borntraeger
2009-01-11 16:29 ` Ingo Molnar
2009-01-11 16:29 ` Ingo Molnar
[not found] ` <20090111162949.GA15338-X9Un+BFzKDI@public.gmane.org>
2009-01-11 16:36 ` Christian Borntraeger
2009-01-11 16:36 ` Christian Borntraeger
[not found] ` <200901111736.24350.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2009-01-11 16:39 ` Ingo Molnar
2009-01-11 16:39 ` Ingo Molnar
[not found] ` <20090111163904.GA21806-X9Un+BFzKDI@public.gmane.org>
2009-01-11 16:56 ` Jeff Chua
2009-01-11 16:56 ` Jeff Chua
[not found] ` <b6a2187b0901110856j3f2ff6fepc19a816178e38a95-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-01-11 18:07 ` Ingo Molnar
2009-01-11 18:07 ` Ingo Molnar
[not found] ` <20090111180714.GB15326-X9Un+BFzKDI@public.gmane.org>
2009-01-13 1:20 ` Jeff Chua
2009-01-13 1:20 ` Jeff Chua
[not found] ` <b6a2187b0901121720s1f9b12ednb76a90dcc7eddc81-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-01-13 1:28 ` Ingo Molnar [this message]
2009-01-13 1:28 ` Ingo Molnar
2009-01-13 2:08 ` Linus Torvalds
2009-01-13 2:08 ` Linus Torvalds
[not found] ` <alpine.LFD.2.00.0901121807070.6528-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-01-13 4:28 ` Jeff Chua
2009-01-13 4:28 ` Jeff Chua
[not found] ` <b6a2187b0901122028w3f85fc9aj41d7c8ac44adb2ed-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-01-13 5:47 ` Jeff Chua
2009-01-13 5:47 ` Jeff Chua
[not found] ` <b6a2187b0901122147o45890cd4lfb6ba7b2908e6ae7-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-01-13 11:32 ` Rafael J. Wysocki
2009-01-13 11:32 ` Rafael J. Wysocki
[not found] ` <200901131232.17941.rjw-KKrjLPT3xs0@public.gmane.org>
2009-01-13 13:30 ` Jeff Chua
2009-01-13 13:30 ` Jeff Chua
2009-01-11 16:10 ` Jeff Chua
2009-01-11 16:10 ` Jeff Chua
2009-01-11 11:16 ` [Bug #12420] WARNING: at drivers/ata/libata-sff.c:1017 ata_sff_hsm_move+0x45e/0x750() Rafael J. Wysocki
2009-01-11 11:16 ` Rafael J. Wysocki
2009-01-11 14:52 ` Alexey Fisher
2009-01-11 14:52 ` Alexey Fisher
2009-01-14 7:35 ` Alexey Rempel
2009-01-14 7:35 ` Alexey Rempel
[not found] ` <496D95BA.4070304-hi6Y0CQ0nG0@public.gmane.org>
2009-01-14 7:40 ` Christian Borntraeger
2009-01-14 7:40 ` Christian Borntraeger
[not found] ` <200901140840.39202.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2009-01-14 10:58 ` Rafael J. Wysocki
2009-01-14 10:58 ` Rafael J. Wysocki
2009-01-11 11:16 ` [Bug #12419] possible circular locking dependency on i915 dma Rafael J. Wysocki
2009-01-11 11:16 ` Rafael J. Wysocki
2009-01-11 11:16 ` [Bug #12428] Build error on latest git Rafael J. Wysocki
2009-01-11 11:16 ` Rafael J. Wysocki
2009-01-11 11:16 ` [Bug #12427] cpumask change causes sparc build bustage Rafael J. Wysocki
2009-01-11 11:16 ` Rafael J. Wysocki
2009-01-11 13:46 ` 2.6.29-rc1: Reported regressions from 2.6.28 Jaswinder Singh Rajput
2009-01-11 13:52 ` Ingo Molnar
2009-01-11 13:52 ` Ingo Molnar
2009-01-11 19:00 ` Rafael J. Wysocki
[not found] ` <200901112001.00394.rjw-KKrjLPT3xs0@public.gmane.org>
2009-01-13 3:24 ` Jaswinder Singh Rajput
2009-01-13 3:24 ` Jaswinder Singh Rajput
2009-01-13 11:23 ` Rafael J. Wysocki
2009-01-13 11:23 ` Rafael J. Wysocki
2009-01-13 3:24 ` Jaswinder Singh Rajput
2009-01-11 19:00 ` Rafael J. Wysocki
2009-01-11 13:52 ` Ingo Molnar
2009-01-11 13:46 ` Jaswinder Singh Rajput
2009-01-11 13:47 ` Ingo Molnar
2009-01-11 13:47 ` Ingo Molnar
2009-01-11 14:22 ` Matthias Heinz
2009-01-11 14:22 ` Matthias Heinz
2009-01-11 14:39 ` Matthias Heinz
2009-01-11 14:39 ` Matthias Heinz
2009-01-11 14:39 ` Matthias Heinz
-- strict thread matches above, loose matches on Subject: below --
2009-01-19 21:28 2.6.29-rc2-git1: " Rafael J. Wysocki
2009-01-19 21:32 ` [Bug #12422] 2.6.28-git can't resume from str Rafael J. Wysocki
2009-01-19 21:32 ` Rafael J. Wysocki
2009-01-20 0:39 ` Harvey Harrison
2009-01-20 0:39 ` Harvey Harrison
2009-01-20 1:46 ` Jeff Chua
2009-01-20 1:46 ` Jeff Chua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090113012800.GA15492@elte.hu \
--to=mingo-x9un+bfzkdi@public.gmane.org \
--cc=borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
--cc=dsd-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org \
--cc=jeff.chua.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=phil-LijsOF1cAEA@public.gmane.org \
--cc=rjw-KKrjLPT3xs0@public.gmane.org \
--cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.