From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Harvey Harrison <harvey.harrison@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
Subject: Re: [PATCH -tip] x86: headers - include linux/types.h instead of asm/types.h
Date: Tue, 13 Jan 2009 15:57:05 +0300 [thread overview]
Message-ID: <20090113125705.GC7682@localhost> (raw)
In-Reply-To: <20090113120905.GB7682@localhost>
[Cyrill Gorcunov - Tue, Jan 13, 2009 at 03:09:05PM +0300]
| Impact: cleanup
|
| 'make headers_check' warns that linux/types.h is
| preferred over asm/types.h. So be it.
|
| Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
| CC: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
| CC: Sam Ravnborg <sam@ravnborg.org>
| CC: Harvey Harrison <harvey.harrison@gmail.com>
| ---
|
| arch/x86/include/asm/e820.h | 2 ++
| arch/x86/include/asm/kvm.h | 2 +-
| arch/x86/include/asm/mce.h | 2 +-
| arch/x86/include/asm/mtrr.h | 1 +
| arch/x86/include/asm/ptrace-abi.h | 2 +-
| arch/x86/include/asm/sigcontext.h | 2 +-
| arch/x86/include/asm/swab.h | 2 +-
| 7 files changed, 8 insertions(+), 5 deletions(-)
|
...
well... on the other hand I'm not sure if it's really
a good idea to include linux/types.h where we need only
__u[8,16] and so on definitions.
Ingo, don't apply this patch please -- have to check
for other ways.
- Cyrill -
next prev parent reply other threads:[~2009-01-13 12:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 12:09 [PATCH -tip] x86: headers - include linux/types.h instead of asm/types.h Cyrill Gorcunov
2009-01-13 12:57 ` Cyrill Gorcunov [this message]
2009-01-13 12:59 ` Ingo Molnar
2009-01-13 13:10 ` Cyrill Gorcunov
2009-01-13 13:25 ` Cyrill Gorcunov
2009-01-13 14:45 ` Ingo Molnar
2009-01-13 14:49 ` Cyrill Gorcunov
2009-01-13 15:06 ` Cyrill Gorcunov
2009-01-13 13:08 ` Jaswinder Singh Rajput
2009-01-13 13:12 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090113125705.GC7682@localhost \
--to=gorcunov@gmail.com \
--cc=harvey.harrison@gmail.com \
--cc=hpa@zytor.com \
--cc=jaswinderrajput@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.