From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Harvey Harrison <harvey.harrison@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
Subject: Re: [PATCH -tip] x86: headers - include linux/types.h instead of asm/types.h
Date: Tue, 13 Jan 2009 18:06:51 +0300 [thread overview]
Message-ID: <20090113150651.GK7682@localhost> (raw)
In-Reply-To: <20090113144956.GJ7682@localhost>
[Cyrill Gorcunov - Tue, Jan 13, 2009 at 05:49:56PM +0300]
| [Ingo Molnar - Tue, Jan 13, 2009 at 03:45:05PM +0100]
| ...
| | >
| | > Until such a file not passed to some *.S. For example for e820.h we have
| | > it included to arch/x86/boot/header.S but fortunately we're bound by
| | > __ASSEMBLY__. So there linux/types.h shouldn't hurt. Will check others
| | > and report then.
| |
| | Any reason to not protect types.h with #ifndef __ASSEMBLY__ ?
| |
| | Ingo
| |
|
| hmm... good question :) letme check
|
| - Cyrill -
Dunno Ingo, it's dubious. I don't like the idea
to start including types.h into any kind of *.S
with #ifndef __ASSEMBLY__ protection. We export it
into user space and I don't remember if it mentioned
somewhere that user is not allowed to use -D__ASSEMBLY__.
Someone more experienced (then me) in this area should
asked first :-)
- Cyrill -
next prev parent reply other threads:[~2009-01-13 15:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 12:09 [PATCH -tip] x86: headers - include linux/types.h instead of asm/types.h Cyrill Gorcunov
2009-01-13 12:57 ` Cyrill Gorcunov
2009-01-13 12:59 ` Ingo Molnar
2009-01-13 13:10 ` Cyrill Gorcunov
2009-01-13 13:25 ` Cyrill Gorcunov
2009-01-13 14:45 ` Ingo Molnar
2009-01-13 14:49 ` Cyrill Gorcunov
2009-01-13 15:06 ` Cyrill Gorcunov [this message]
2009-01-13 13:08 ` Jaswinder Singh Rajput
2009-01-13 13:12 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090113150651.GK7682@localhost \
--to=gorcunov@gmail.com \
--cc=harvey.harrison@gmail.com \
--cc=hpa@zytor.com \
--cc=jaswinderrajput@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.