From: "Shawn O. Pearce" <spearce@spearce.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
git@vger.kernel.org, Miklos Vajna <vmiklos@frugalware.org>
Subject: Re: [RESEND PATCH] fast-import: Cleanup mode setting.
Date: Tue, 13 Jan 2009 18:17:51 -0800 [thread overview]
Message-ID: <20090114021751.GW10179@spearce.org> (raw)
In-Reply-To: <alpine.DEB.1.00.0901140308200.3586@pacific.mpi-cbg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> On Wed, 14 Jan 2009, Felipe Contreras wrote:
>
> > "S_IFREG | mode" probably is only required for 0644 and 0755.
>
> Why should we want to have that patch? IOW what does it fix, and what
> might it break?
It cleans up the code to make it more readable.
It makes no sense to be doing S_IFREG | S_IFLINK, which happens when
the input is for a symlink. It doesn't break anything to do that |
operation, but it also looks damn odd when reading the function.
--
Shawn.
next prev parent reply other threads:[~2009-01-14 2:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 1:37 [RESEND PATCH] fast-import: Cleanup mode setting Felipe Contreras
2009-01-14 2:08 ` Johannes Schindelin
2009-01-14 2:17 ` Shawn O. Pearce [this message]
2009-01-14 2:28 ` Johannes Schindelin
2009-01-14 2:29 ` Shawn O. Pearce
2009-01-14 2:46 ` Felipe Contreras
2009-01-14 2:51 ` Shawn O. Pearce
2009-01-14 2:16 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090114021751.GW10179@spearce.org \
--to=spearce@spearce.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.