From: "Shawn O. Pearce" <spearce@spearce.org>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org, Miklos Vajna <vmiklos@frugalware.org>
Subject: Re: [RESEND PATCH] fast-import: Cleanup mode setting.
Date: Tue, 13 Jan 2009 18:51:11 -0800 [thread overview]
Message-ID: <20090114025111.GY10179@spearce.org> (raw)
In-Reply-To: <94a0d4530901131846u2121e433ka8620fbb37c8470b@mail.gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> wrote:
>
> How about the attached patch?
>
> "S_IFREG | mode" probably is only required for 0644 and 0755.
>
> It doesn't make sense to do S_IFREG | S_IFLINK (0100000 | 0120000),
> since no bits are changed.
Looks fine to me.
--
Shawn.
next prev parent reply other threads:[~2009-01-14 2:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 1:37 [RESEND PATCH] fast-import: Cleanup mode setting Felipe Contreras
2009-01-14 2:08 ` Johannes Schindelin
2009-01-14 2:17 ` Shawn O. Pearce
2009-01-14 2:28 ` Johannes Schindelin
2009-01-14 2:29 ` Shawn O. Pearce
2009-01-14 2:46 ` Felipe Contreras
2009-01-14 2:51 ` Shawn O. Pearce [this message]
2009-01-14 2:16 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090114025111.GY10179@spearce.org \
--to=spearce@spearce.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.