All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: bzolnier@gmail.com
Cc: linux-ide@vger.kernel.org,
	Kevin Hilman <khilman@deeprootsystems.com>,
	Sergei Shtylyov <sshtylyov@ru.mvista.com>
Subject: [patch 2.6.29-rc2] palm_bk3710 buildfix
Date: Sun, 18 Jan 2009 08:33:53 -0800	[thread overview]
Message-ID: <200901180833.53969.david-b@pacbell.net> (raw)

From: David Brownell <dbrownell@users.sourceforge.net>
Subject: drivers/ide/palm_bk3710.c buildfix

  CC      drivers/ide/palm_bk3710.o
drivers/ide/palm_bk3710.c: In function 'palm_bk3710_probe':
drivers/ide/palm_bk3710.c:382: warning: assignment makes integer from pointer without a cast

Someone should fix hw_regs_t to neither be a typedef, nor
use "unsigned long" where it should use "void __iomem *".

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
---
 drivers/ide/palm_bk3710.c |   11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

--- a/drivers/ide/palm_bk3710.c
+++ b/drivers/ide/palm_bk3710.c
@@ -346,7 +346,8 @@ static int __init palm_bk3710_probe(stru
 {
 	struct clk *clk;
 	struct resource *mem, *irq;
-	unsigned long base, rate;
+	void __iomem *base;
+	unsigned long rate;
 	int i, rc;
 	hw_regs_t hw, *hws[] = { &hw, NULL, NULL, NULL };
 
@@ -382,11 +383,13 @@ static int __init palm_bk3710_probe(stru
 	base = IO_ADDRESS(mem->start);
 
 	/* Configure the Palm Chip controller */
-	palm_bk3710_chipinit((void __iomem *)base);
+	palm_bk3710_chipinit(base);
 
 	for (i = 0; i < IDE_NR_PORTS - 2; i++)
-		hw.io_ports_array[i] = base + IDE_PALM_ATA_PRI_REG_OFFSET + i;
-	hw.io_ports.ctl_addr = base + IDE_PALM_ATA_PRI_CTL_OFFSET;
+		hw.io_ports_array[i] = (unsigned long)
+				(base + IDE_PALM_ATA_PRI_REG_OFFSET + i);
+	hw.io_ports.ctl_addr = (unsigned long)
+			(base + IDE_PALM_ATA_PRI_CTL_OFFSET);
 	hw.irq = irq->start;
 	hw.dev = &pdev->dev;
 	hw.chipset = ide_palm3710;

             reply	other threads:[~2009-01-18 16:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-18 16:33 David Brownell [this message]
2009-01-18 17:14 ` [patch 2.6.29-rc2] palm_bk3710 buildfix Sergei Shtylyov
2009-01-19  0:29   ` David Brownell
2009-01-19  8:35     ` Sergei Shtylyov
2009-01-19  8:57       ` Sergei Shtylyov
2009-01-19 12:07         ` Bartlomiej Zolnierkiewicz
2009-01-19 13:06           ` Sergei Shtylyov
2009-01-19 14:14             ` Sergei Shtylyov
2009-01-19 12:00   ` Bartlomiej Zolnierkiewicz
2009-01-19 13:03     ` Sergei Shtylyov
2009-01-19 13:21       ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200901180833.53969.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=bzolnier@gmail.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=sshtylyov@ru.mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.