All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Heidelberg <markus.heidelberg@web.de>
To: Jeff King <peff@peff.net>
Cc: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>,
	"Junio C Hamano" <gitster@pobox.com>,
	git@vger.kernel.org
Subject: [PATCH 2/2] move the color variables to color.c
Date: Sun, 18 Jan 2009 21:39:12 +0100	[thread overview]
Message-ID: <200901182139.13995.markus.heidelberg@web.de> (raw)
In-Reply-To: <200901182137.16562.markus.heidelberg@web.de>

To be consistent with where the branch color variable is located now,
move the variables for diff and status color to the same place.

Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
---
 color.c     |    4 ++--
 color.h     |    2 ++
 diff.c      |    1 -
 diff.h      |    1 -
 wt-status.c |    1 -
 wt-status.h |    1 -
 6 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/color.c b/color.c
index 7a8bf6e..b23c39c 100644
--- a/color.c
+++ b/color.c
@@ -1,12 +1,12 @@
 #include "cache.h"
 #include "color.h"
-#include "diff.h"
-#include "wt-status.h"
 
 #define COLOR_RESET "\033[m"
 
 int git_use_color_default = 0;
 int branch_use_color = -1;
+int diff_use_color_default = -1;
+int wt_status_use_color = -1;
 
 static int parse_color(const char *name, int len)
 {
diff --git a/color.h b/color.h
index 6924848..3b47d99 100644
--- a/color.h
+++ b/color.h
@@ -10,6 +10,8 @@
 extern int git_use_color_default;
 
 extern int branch_use_color;
+extern int diff_use_color_default;
+extern int wt_status_use_color;
 
 /*
  * Use this instead of git_default_config if you need the value of color.ui.
diff --git a/diff.c b/diff.c
index d235482..4bd068c 100644
--- a/diff.c
+++ b/diff.c
@@ -22,7 +22,6 @@
 static int diff_detect_rename_default;
 static int diff_rename_limit_default = 200;
 static int diff_suppress_blank_empty;
-int diff_use_color_default = -1;
 static const char *external_diff_cmd_cfg;
 int diff_auto_refresh_index = 1;
 static int diff_mnemonic_prefix;
diff --git a/diff.h b/diff.h
index 4d5a327..f2c9984 100644
--- a/diff.h
+++ b/diff.h
@@ -188,7 +188,6 @@ extern void diff_unmerge(struct diff_options *,
 
 extern int git_diff_basic_config(const char *var, const char *value, void *cb);
 extern int git_diff_ui_config(const char *var, const char *value, void *cb);
-extern int diff_use_color_default;
 extern void diff_setup(struct diff_options *);
 extern int diff_opt_parse(struct diff_options *, const char **, int);
 extern int diff_setup_done(struct diff_options *);
diff --git a/wt-status.c b/wt-status.c
index 96ff2f8..5c3742b 100644
--- a/wt-status.c
+++ b/wt-status.c
@@ -12,7 +12,6 @@
 #include "remote.h"
 
 int wt_status_relative_paths = 1;
-int wt_status_use_color = -1;
 int wt_status_submodule_summary;
 static char wt_status_colors[][COLOR_MAXLEN] = {
 	"",         /* WT_STATUS_HEADER: normal */
diff --git a/wt-status.h b/wt-status.h
index 78add09..6258fd0 100644
--- a/wt-status.h
+++ b/wt-status.h
@@ -36,7 +36,6 @@ struct wt_status {
 };
 
 int git_status_config(const char *var, const char *value, void *cb);
-extern int wt_status_use_color;
 extern int wt_status_relative_paths;
 void wt_status_prepare(struct wt_status *s);
 void wt_status_print(struct wt_status *s);
-- 
1.6.1.208.g3a5f4

  reply	other threads:[~2009-01-18 20:39 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-16 15:06 [PATCH 3/3] Adds a #!bash to the top of bash completions so that editors can recognize, it as a bash script. Also adds a few simple comments above commands that, take arguments. The comments are meant to remind editors of potential, problems that Baz
2009-01-17  1:40 ` Jeff King
2009-01-17 12:37   ` Markus Heidelberg
2009-01-17 15:21     ` Jeff King
2009-01-17 15:32       ` [PATCH 1/2] color: make it easier for non-config to parse color specs Jeff King
2009-01-18 17:10         ` René Scharfe
2009-01-18 17:28           ` Jeff King
2009-01-18 17:36             ` Jeff King
2009-01-18 17:45             ` René Scharfe
2009-01-18 18:06               ` Jeff King
2009-01-17 15:38       ` [PATCH 2/2] expand --pretty=format color options Jeff King
2009-01-18 17:13         ` René Scharfe
2009-01-18 17:37           ` Jeff King
2009-01-18 19:43             ` Jeff King
2009-01-18 19:53               ` Jeff King
2009-01-18 20:37                 ` [PATCH 1/2] handle color.ui at a central place Markus Heidelberg
2009-01-18 20:39                   ` Markus Heidelberg [this message]
2009-01-20  4:04                   ` Jeff King
2009-01-21 22:35                     ` Markus Heidelberg
2009-01-22  0:00                       ` Jeff King
2009-01-22  0:13                         ` Markus Heidelberg
2009-01-23  6:13                           ` Junio C Hamano
2009-01-24 11:28                             ` Markus Heidelberg
2009-01-24 14:14                               ` Johannes Schindelin
2009-01-24 14:23                                 ` Markus Heidelberg
2009-01-24 18:36                               ` Junio C Hamano
2009-01-24 19:17                                 ` Jeff King
2009-01-24 20:26                                   ` Junio C Hamano
2009-01-24 20:45                                     ` Jeff King
2009-01-25 14:15                                 ` Markus Heidelberg
2009-01-19 23:10                 ` [PATCH 2/2] expand --pretty=format color options Junio C Hamano
2009-01-20  4:06                   ` Jeff King
2009-01-20 10:27                     ` Johannes Schindelin
2009-01-20 10:36                       ` Johannes Schindelin
2009-01-20 14:23                         ` Jeff King
2009-01-20 14:58                           ` Johannes Schindelin
2009-01-20 19:21                             ` Jeff King
2009-01-17 15:39       ` Cyellow, was Re: [a way-too-long line] Johannes Schindelin
2009-01-17 15:40         ` Jeff King
2009-01-17 15:46           ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200901182139.13995.markus.heidelberg@web.de \
    --to=markus.heidelberg@web.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=rene.scharfe@lsrfire.ath.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.