From: Markus Heidelberg <markus.heidelberg@web.de>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Junio C Hamano" <gitster@pobox.com>, "Jeff King" <peff@peff.net>,
"René Scharfe" <rene.scharfe@lsrfire.ath.cx>,
git@vger.kernel.org
Subject: Re: [PATCH 1/2] handle color.ui at a central place
Date: Sat, 24 Jan 2009 15:23:24 +0100 [thread overview]
Message-ID: <200901241523.24845.markus.heidelberg@web.de> (raw)
In-Reply-To: <alpine.DEB.1.00.0901241513460.13232@racer>
Johannes Schindelin, 24.01.2009:
> Hi,
>
> On Sat, 24 Jan 2009, Markus Heidelberg wrote:
>
> > format-patch is perhaps the only place where the commit has broken
> > things, because I didn't find other places, where color config options
> > were set
(and evaluated)
> > , but not the corresponding variables. So it seems as if only
> > format-patch needed code like this to turn off the colors.
>
> So you want to add a test case when you resubmit your patch...
I'm not sure, whether it should be resubmitted at all. As Jeff pointed
out, there should be a better way to clean up the color (and color.ui)
handling.
Markus
next prev parent reply other threads:[~2009-01-24 14:24 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-16 15:06 [PATCH 3/3] Adds a #!bash to the top of bash completions so that editors can recognize, it as a bash script. Also adds a few simple comments above commands that, take arguments. The comments are meant to remind editors of potential, problems that Baz
2009-01-17 1:40 ` Jeff King
2009-01-17 12:37 ` Markus Heidelberg
2009-01-17 15:21 ` Jeff King
2009-01-17 15:32 ` [PATCH 1/2] color: make it easier for non-config to parse color specs Jeff King
2009-01-18 17:10 ` René Scharfe
2009-01-18 17:28 ` Jeff King
2009-01-18 17:36 ` Jeff King
2009-01-18 17:45 ` René Scharfe
2009-01-18 18:06 ` Jeff King
2009-01-17 15:38 ` [PATCH 2/2] expand --pretty=format color options Jeff King
2009-01-18 17:13 ` René Scharfe
2009-01-18 17:37 ` Jeff King
2009-01-18 19:43 ` Jeff King
2009-01-18 19:53 ` Jeff King
2009-01-18 20:37 ` [PATCH 1/2] handle color.ui at a central place Markus Heidelberg
2009-01-18 20:39 ` [PATCH 2/2] move the color variables to color.c Markus Heidelberg
2009-01-20 4:04 ` [PATCH 1/2] handle color.ui at a central place Jeff King
2009-01-21 22:35 ` Markus Heidelberg
2009-01-22 0:00 ` Jeff King
2009-01-22 0:13 ` Markus Heidelberg
2009-01-23 6:13 ` Junio C Hamano
2009-01-24 11:28 ` Markus Heidelberg
2009-01-24 14:14 ` Johannes Schindelin
2009-01-24 14:23 ` Markus Heidelberg [this message]
2009-01-24 18:36 ` Junio C Hamano
2009-01-24 19:17 ` Jeff King
2009-01-24 20:26 ` Junio C Hamano
2009-01-24 20:45 ` Jeff King
2009-01-25 14:15 ` Markus Heidelberg
2009-01-19 23:10 ` [PATCH 2/2] expand --pretty=format color options Junio C Hamano
2009-01-20 4:06 ` Jeff King
2009-01-20 10:27 ` Johannes Schindelin
2009-01-20 10:36 ` Johannes Schindelin
2009-01-20 14:23 ` Jeff King
2009-01-20 14:58 ` Johannes Schindelin
2009-01-20 19:21 ` Jeff King
2009-01-17 15:39 ` Cyellow, was Re: [a way-too-long line] Johannes Schindelin
2009-01-17 15:40 ` Jeff King
2009-01-17 15:46 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901241523.24845.markus.heidelberg@web.de \
--to=markus.heidelberg@web.de \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.