Re: [RFC][PATCH] at91_ide driver

[Stanislaw Gruszka <stf_xl@wp.pl>]

Witam :)

On Friday 16 January 2009 17:58, Bartlomiej Zolnierkiewicz wrote:
> Well... there shouldn't be much problem with:
>
> * adding ->irq_handler method to struct ide_port_info and struct ide_host
>
>   [ which reminds me that struct ide_port_info would be better named struct
>     ide_host_info and IIRC somebody has already noticed it in the past ;-)
> ]
>
> * exporting ide_intr()
>
> * adding ide_interrupt() wrapper around ide_intr() which will do sth like:
>
> 	if (host->irq_handler)
> 		return host->irq_handler()
> 	else
> 		return ide_intr()
>
IMHO (slightly) better way is requesting irq handler directly
in init_irq() e.g: 

irq_func = host->irq_handler;
if (!irq_func)
	irq_func =  &ide_intr;
if (request_irq(hwif->irq, irq_func, sa,hwif->name,hwgroup))
                        goto out_unlink;

Cheers
Stanislaw Gruszka