Re: [RFC][PATCH] at91_ide driver

[Stanislaw Gruszka <stf_xl@wp.pl>]

On Friday 16 January 2009 18:43, Bartlomiej Zolnierkiewicz wrote:
> > +#if 0
> > +	/* In 12-0275-01 version of the PCB address
> > +	 * lines CF_A0 and CF_A2 are swapped */
> > +	hw.io_ports.data_addr =	tf_base + 0;
> > +	hw.io_ports.error_addr = tf_base + 4;
> > +	hw.io_ports.nsect_addr = tf_base + 2;
> > +	hw.io_ports.lbal_addr = tf_base + 6;
> > +	hw.io_ports.lbam_addr = tf_base + 1;
> > +	hw.io_ports.lbah_addr = tf_base + 5;
> > +	hw.io_ports.device_addr = tf_base + 3;
> > +	hw.io_ports.command_addr = tf_base + 7;
> > +#else
> > +	/* Proper lines addresses */
> > +	hw.io_ports.data_addr = tf_base + 0;
> > +	hw.io_ports.error_addr = tf_base + 1;
> > +	hw.io_ports.nsect_addr = tf_base + 2;
> > +	hw.io_ports.lbal_addr = tf_base + 3;
> > +	hw.io_ports.lbam_addr = tf_base + 4;
> > +	hw.io_ports.lbah_addr =	tf_base + 5;
> > +	hw.io_ports.device_addr = tf_base + 6;
> > +	hw.io_ports.command_addr = tf_base + 7;
> > +#endif
>
> How's about using enums for offsets, i.e.
>
> enum {
> #if 0
> ...
> 	AT91_IDE_ERROR_ADDR_OFFSET = 4,
> ...
> #else
> ...
> 	AT91_IDE_ERROR_ADDR_OFFSET = 1,
> ...
> #endif
> };
Oh, I remove this code. It is just workaround for stupid
hardware bug.