From: Ingo Molnar <mingo@elte.hu>
To: Gary Hade <garyhade@us.ibm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
yhlu.kernel@gmail.com, lcm@us.ibm.com, x86@kernel.org
Subject: Re: [PATCH] x86_64: remove kernel_physical_mapping_init() from init section
Date: Tue, 20 Jan 2009 00:32:27 +0100 [thread overview]
Message-ID: <20090119233227.GA310@elte.hu> (raw)
In-Reply-To: <20090119214641.GB7476@us.ibm.com>
* Gary Hade <garyhade@us.ibm.com> wrote:
> kernel_physical_mapping_init() is called during memory hotplug so it
> does not belong in the init section.
>
> If the kernel is built with CONFIG_DEBUG_SECTION_MISMATCH=y on the make
> command line, arch/x86/mm/init_64.c is compiled with the
> -fno-inline-functions-called-once gcc option defeating inlining of
> kernel_physical_mapping_init() within init_memory_mapping(). When
> kernel_physical_mapping_init() is not inlined it is placed in the
> .init.text section according to the __init in it's current declaration.
> A later call to kernel_physical_mapping_init() during a memory hotplug
> operation encounters an int3 trap because the .init.text section memory
> has been freed. This patch eliminates the crash caused by the int3 trap
> by moving the non-inlined kernel_physical_mapping_init() from .init.text
> to .meminit.text.
>
> Signed-off-by: Gary Hade <garyhade@us.ibm.com>
applied to tip/x86/urgent, thanks Gary!
Ingo
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: Gary Hade <garyhade@us.ibm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
yhlu.kernel@gmail.com, lcm@us.ibm.com, x86@kernel.org
Subject: Re: [PATCH] x86_64: remove kernel_physical_mapping_init() from init section
Date: Tue, 20 Jan 2009 00:32:27 +0100 [thread overview]
Message-ID: <20090119233227.GA310@elte.hu> (raw)
In-Reply-To: <20090119214641.GB7476@us.ibm.com>
* Gary Hade <garyhade@us.ibm.com> wrote:
> kernel_physical_mapping_init() is called during memory hotplug so it
> does not belong in the init section.
>
> If the kernel is built with CONFIG_DEBUG_SECTION_MISMATCH=y on the make
> command line, arch/x86/mm/init_64.c is compiled with the
> -fno-inline-functions-called-once gcc option defeating inlining of
> kernel_physical_mapping_init() within init_memory_mapping(). When
> kernel_physical_mapping_init() is not inlined it is placed in the
> .init.text section according to the __init in it's current declaration.
> A later call to kernel_physical_mapping_init() during a memory hotplug
> operation encounters an int3 trap because the .init.text section memory
> has been freed. This patch eliminates the crash caused by the int3 trap
> by moving the non-inlined kernel_physical_mapping_init() from .init.text
> to .meminit.text.
>
> Signed-off-by: Gary Hade <garyhade@us.ibm.com>
applied to tip/x86/urgent, thanks Gary!
Ingo
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-01-19 23:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 21:46 [PATCH] x86_64: remove kernel_physical_mapping_init() from init section Gary Hade
2009-01-19 21:46 ` Gary Hade
2009-01-19 23:32 ` Ingo Molnar [this message]
2009-01-19 23:32 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090119233227.GA310@elte.hu \
--to=mingo@elte.hu \
--cc=garyhade@us.ibm.com \
--cc=lcm@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=x86@kernel.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.