From: Paul Mundt <lethal@linux-sh.org>
To: Adrian McMenamin <lkmladrian@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, linux-sh <linux-sh@vger.kernel.org>
Subject: Re: Bug: Latest (rc2 and beyond) kernel fails on Dreamcast
Date: Tue, 20 Jan 2009 00:48:31 +0000 [thread overview]
Message-ID: <20090120004830.GA12965@linux-sh.org> (raw)
In-Reply-To: <8b67d60901191433u51d062bgffa523c7da811cb8@mail.gmail.com>
On Mon, Jan 19, 2009 at 10:33:57PM +0000, Adrian McMenamin wrote:
> 2009/1/19 Adrian McMenamin <lkmladrian@gmail.com>:
> > I haven't had time to look at this, but the most up to date kernel
> > (and the one of around a week ago also) fails to boot, seemingly
> > seeking an IP address for the 8139too based NIC.
>
> > [ 4.664236] Sending DHCP requests .<3>eth0: PCI Bus error 2200.
> > [ 4.669582] eth0: PCI Bus error 2200.
>
> And the bisection reveals the following:
>
> adrian@bossclass:~/linux-2.6$ git bisect bad
> 58c6d3dfe436eb8cfb451981d8fdc9044eaf42da is first bad commit
> commit 58c6d3dfe436eb8cfb451981d8fdc9044eaf42da
> Author: Johannes Weiner <hannes@cmpxchg.org>
> Date: Tue Jan 6 14:43:10 2009 -0800
>
> dma-coherent: catch oversized requests to dma_alloc_from_coherent()
>
> Prevent passing an order to bitmap_find_free_region() that is larger than
> the actual bitmap can represent.
>
> These requests can come from device drivers that have no idea how big the
> dma region is and need to rely on dma_alloc_from_coherent() to sort it out
> for them.
>
> Reported-by: Guennadi Liakhovetski <lg@denx.de>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Pekka Enberg <penberg@cs.helsinki.fi>
> Cc: Dmitry Baryshkov <dbaryshkov@gmail.com>
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
>
> :040000 040000 5c8a694b778f36a3254103d99cb73b561cb84565
> 5efd4e32eb145f32ca4e96aefbea08f4f8f4d27d M kernel
The dreamcast uses a 32kB coherent area for PCI DMA, which all of the
8139too allocations should fit under just fine. What does
dma_alloc_from_coherent() say the requested size is, vs the per-device
memory size for each allocation?
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: Adrian McMenamin <lkmladrian@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, linux-sh <linux-sh@vger.kernel.org>
Subject: Re: Bug: Latest (rc2 and beyond) kernel fails on Dreamcast
Date: Tue, 20 Jan 2009 09:48:31 +0900 [thread overview]
Message-ID: <20090120004830.GA12965@linux-sh.org> (raw)
In-Reply-To: <8b67d60901191433u51d062bgffa523c7da811cb8@mail.gmail.com>
On Mon, Jan 19, 2009 at 10:33:57PM +0000, Adrian McMenamin wrote:
> 2009/1/19 Adrian McMenamin <lkmladrian@gmail.com>:
> > I haven't had time to look at this, but the most up to date kernel
> > (and the one of around a week ago also) fails to boot, seemingly
> > seeking an IP address for the 8139too based NIC.
>
> > [ 4.664236] Sending DHCP requests .<3>eth0: PCI Bus error 2200.
> > [ 4.669582] eth0: PCI Bus error 2200.
>
> And the bisection reveals the following:
>
> adrian@bossclass:~/linux-2.6$ git bisect bad
> 58c6d3dfe436eb8cfb451981d8fdc9044eaf42da is first bad commit
> commit 58c6d3dfe436eb8cfb451981d8fdc9044eaf42da
> Author: Johannes Weiner <hannes@cmpxchg.org>
> Date: Tue Jan 6 14:43:10 2009 -0800
>
> dma-coherent: catch oversized requests to dma_alloc_from_coherent()
>
> Prevent passing an order to bitmap_find_free_region() that is larger than
> the actual bitmap can represent.
>
> These requests can come from device drivers that have no idea how big the
> dma region is and need to rely on dma_alloc_from_coherent() to sort it out
> for them.
>
> Reported-by: Guennadi Liakhovetski <lg@denx.de>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Pekka Enberg <penberg@cs.helsinki.fi>
> Cc: Dmitry Baryshkov <dbaryshkov@gmail.com>
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
>
> :040000 040000 5c8a694b778f36a3254103d99cb73b561cb84565
> 5efd4e32eb145f32ca4e96aefbea08f4f8f4d27d M kernel
The dreamcast uses a 32kB coherent area for PCI DMA, which all of the
8139too allocations should fit under just fine. What does
dma_alloc_from_coherent() say the requested size is, vs the per-device
memory size for each allocation?
next prev parent reply other threads:[~2009-01-20 0:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 0:26 Bug: Latest (rc2 and beyond) kernel fails on Dreamcast Adrian McMenamin
2009-01-19 0:26 ` Adrian McMenamin
2009-01-19 22:33 ` Adrian McMenamin
2009-01-20 0:48 ` Paul Mundt [this message]
2009-01-20 0:48 ` Paul Mundt
2009-01-20 20:40 ` Adrian McMenamin
2009-01-20 20:40 ` Adrian McMenamin
2009-01-20 21:20 ` Adrian McMenamin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090120004830.GA12965@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=lkmladrian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.