All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Pierre Ossman <drzeus-sdhci@drzeus.cx>
Cc: sdhci-devel@list.drzeus.cx, Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org, Liu Dave <DaveLiu@freescale.com>,
	Joe D'Abbraccio <Joe.D'abbraccio@freescale.com>,
	linuxppc-dev@ozlabs.org, Konjin Lai <Konjin.Lai@freescale.com>,
	Ben Dooks <ben-linux@fluff.org>, Xie Xiaobo <X.Xie@freescale.com>
Subject: [PATCH 08/10] sdhci: Add set_clock callback
Date: Thu, 22 Jan 2009 05:00:37 +0300	[thread overview]
Message-ID: <20090122020037.GH11492@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20090122015649.GA6835@oksana.dev.rtsoft.ru>

FSL eSDHC hosts have incompatible register map to manage the SDCLK.
This patch adds set_clock callback so that drivers could overwrite
set_clock behaviour.

Similar patch[1] was posted by Ben Dooks, though in Ben's version the
callback is named change_clock, plus the patch has some unrelated bits
that makes the patch difficult to reuse.

[1] http://lkml.org/lkml/2008/12/2/160

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
 drivers/mmc/host/sdhci.c |    5 +++++
 drivers/mmc/host/sdhci.h |    2 ++
 2 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 9ac088a..e456ae0 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -959,6 +959,11 @@ static void sdhci_set_clock(struct sdhci_host *host, unsigned int clock)
 	if (clock == host->clock)
 		return;
 
+	if (host->ops->set_clock) {
+		host->ops->set_clock(host, clock);
+		return;
+	}
+
 	sdhci_writew(host, SDHCI_CLOCK_CONTROL, 0);
 
 	if (clock == 0)
diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
index 7e3b01f..39cfd5a 100644
--- a/drivers/mmc/host/sdhci.h
+++ b/drivers/mmc/host/sdhci.h
@@ -303,6 +303,8 @@ struct sdhci_ops {
 	void		(*writew)(struct sdhci_host *host, int reg, u16 val);
 	void		(*writeb)(struct sdhci_host *host, int reg, u8 val);
 
+	void	(*set_clock)(struct sdhci_host *host, unsigned int clock);
+
 	int		(*enable_dma)(struct sdhci_host *host);
 };
 
-- 
1.5.6.5

WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Pierre Ossman <drzeus-sdhci@drzeus.cx>
Cc: Ben Dooks <ben-linux@fluff.org>, Arnd Bergmann <arnd@arndb.de>,
	Kumar Gala <galak@kernel.crashing.org>,
	Liu Dave <DaveLiu@freescale.com>,
	Xie Xiaobo <X.Xie@freescale.com>,
	Konjin Lai <Konjin.Lai@freescale.com>,
	"Joe D'Abbraccio" <Joe.D'abbraccio@freescale.com>,
	sdhci-devel@list.drzeus.cx, linux-kernel@vger.kernel.org,
	linuxppc-dev@ozlabs.org
Subject: [PATCH 08/10] sdhci: Add set_clock callback
Date: Thu, 22 Jan 2009 05:00:37 +0300	[thread overview]
Message-ID: <20090122020037.GH11492@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20090122015649.GA6835@oksana.dev.rtsoft.ru>

FSL eSDHC hosts have incompatible register map to manage the SDCLK.
This patch adds set_clock callback so that drivers could overwrite
set_clock behaviour.

Similar patch[1] was posted by Ben Dooks, though in Ben's version the
callback is named change_clock, plus the patch has some unrelated bits
that makes the patch difficult to reuse.

[1] http://lkml.org/lkml/2008/12/2/160

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
 drivers/mmc/host/sdhci.c |    5 +++++
 drivers/mmc/host/sdhci.h |    2 ++
 2 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 9ac088a..e456ae0 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -959,6 +959,11 @@ static void sdhci_set_clock(struct sdhci_host *host, unsigned int clock)
 	if (clock == host->clock)
 		return;
 
+	if (host->ops->set_clock) {
+		host->ops->set_clock(host, clock);
+		return;
+	}
+
 	sdhci_writew(host, SDHCI_CLOCK_CONTROL, 0);
 
 	if (clock == 0)
diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
index 7e3b01f..39cfd5a 100644
--- a/drivers/mmc/host/sdhci.h
+++ b/drivers/mmc/host/sdhci.h
@@ -303,6 +303,8 @@ struct sdhci_ops {
 	void		(*writew)(struct sdhci_host *host, int reg, u16 val);
 	void		(*writeb)(struct sdhci_host *host, int reg, u8 val);
 
+	void	(*set_clock)(struct sdhci_host *host, unsigned int clock);
+
 	int		(*enable_dma)(struct sdhci_host *host);
 };
 
-- 
1.5.6.5


  parent reply	other threads:[~2009-01-22  2:00 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-22  1:56 [PATCH RFC 0/10] Freescale "eSDHC" SDHCI support (was [PATCH] mmc: Add driver for Freescale eSDHC controllers) Anton Vorontsov
2009-01-22  1:56 ` Anton Vorontsov
2009-01-22  1:59 ` [PATCH 01/10] sdhci: Add quirk for controllers with no end-of-busy IRQ Anton Vorontsov
2009-01-22  1:59   ` Anton Vorontsov
2009-01-22  2:00 ` [PATCH 02/10] sdhci: Add support for bus-specific IO memory accessors Anton Vorontsov
2009-01-22  2:00   ` Anton Vorontsov
2009-01-22 11:55   ` Arnd Bergmann
2009-01-22 11:55     ` Arnd Bergmann
2009-01-22 18:31     ` Anton Vorontsov
2009-01-22 18:31       ` Anton Vorontsov
2009-01-22  2:00 ` [PATCH 03/10] sdhci: Add support for card-detection polling Anton Vorontsov
2009-01-22  2:00   ` Anton Vorontsov
2009-01-22  2:00 ` [PATCH 04/10] sdhci: Add support for hosts reporting inverted write-protect state Anton Vorontsov
2009-01-22  2:00   ` Anton Vorontsov
2009-01-22  2:00 ` [PATCH 05/10] sdhci: Add support for hosts with strict 32 bit addressing Anton Vorontsov
2009-01-22  2:00   ` Anton Vorontsov
2009-01-22  2:00 ` [PATCH 06/10] sdhci: Add quirk to suppress PIO interrupts during DMA transfers Anton Vorontsov
2009-01-22  2:00   ` Anton Vorontsov
2009-01-22  2:00 ` [PATCH 07/10] sdhci: Add support for hosts that don't specify clocks in the cap. register Anton Vorontsov
2009-01-22  2:00   ` Anton Vorontsov
2009-01-22  2:00 ` Anton Vorontsov [this message]
2009-01-22  2:00   ` [PATCH 08/10] sdhci: Add set_clock callback Anton Vorontsov
2009-01-22  2:00 ` [PATCH 09/10] sdhci: Add quirk for Freescale eSDHC controllers Anton Vorontsov
2009-01-22  2:00   ` Anton Vorontsov
2009-01-22  2:00 ` [PATCH 10/10] mmc: Add OpenFirmware bindings for SDHCI driver Anton Vorontsov
2009-01-22  2:00   ` Anton Vorontsov
2009-01-22 12:05   ` Arnd Bergmann
2009-01-22 12:05     ` Arnd Bergmann
2009-01-22 19:15   ` Kumar Gala
2009-01-22 19:15     ` Kumar Gala
2009-01-25  6:42   ` Matt Sealey
2009-01-25  6:42     ` Matt Sealey
2009-01-26 22:26     ` M. Warner Losh
2009-01-26 22:26       ` M. Warner Losh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090122020037.GH11492@oksana.dev.rtsoft.ru \
    --to=avorontsov@ru.mvista.com \
    --cc=DaveLiu@freescale.com \
    --cc=Joe.D'abbraccio@freescale.com \
    --cc=Konjin.Lai@freescale.com \
    --cc=X.Xie@freescale.com \
    --cc=arnd@arndb.de \
    --cc=ben-linux@fluff.org \
    --cc=drzeus-sdhci@drzeus.cx \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=sdhci-devel@list.drzeus.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.