From: Christoph Hellwig <hch@infradead.org>
To: Mikulas Patocka <mpatocka@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
xfs@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: spurious -ENOSPC on XFS
Date: Thu, 22 Jan 2009 15:59:13 -0500 [thread overview]
Message-ID: <20090122205913.GA30859@infradead.org> (raw)
In-Reply-To: <20090120232422.GF10158@disturbed>
On Wed, Jan 21, 2009 at 10:24:22AM +1100, Dave Chinner wrote:
> Right, so you need to use internal xfs sync functions that don't
> have these problems. That is:
>
> error = xfs_sync_inodes(ip->i_mount, SYNC_DELWRI|SYNC_WAIT);
>
> will do a blocking flush of all the inodes without deadlocks occurring.
> Then you can remove the 500ms wait.
I've given this a try with Eric's testcase from #724 in the oss bugzilla,
but it's not enough yet. I thinks that's because SYNC_WAIT is rather
meaningless for data writeout, and we need SYNC_IOWAIT instead. The
patch below gets the testcase working for me:
Index: linux-2.6/fs/xfs/linux-2.6/xfs_sync.c
===================================================================
--- linux-2.6.orig/fs/xfs/linux-2.6/xfs_sync.c 2009-01-22 06:29:30.646141628 +0100
+++ linux-2.6/fs/xfs/linux-2.6/xfs_sync.c 2009-01-22 21:57:53.073864570 +0100
@@ -446,7 +446,9 @@ xfs_flush_device_work(
void *arg)
{
struct inode *inode = arg;
- sync_blockdev(mp->m_super->s_bdev);
+
+ xfs_sync_inodes(mp, SYNC_DELWRI);
+ xfs_sync_inodes(mp, SYNC_DELWRI | SYNC_IOWAIT);
iput(inode);
}
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Mikulas Patocka <mpatocka@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
xfs@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: spurious -ENOSPC on XFS
Date: Thu, 22 Jan 2009 15:59:13 -0500 [thread overview]
Message-ID: <20090122205913.GA30859@infradead.org> (raw)
In-Reply-To: <20090120232422.GF10158@disturbed>
On Wed, Jan 21, 2009 at 10:24:22AM +1100, Dave Chinner wrote:
> Right, so you need to use internal xfs sync functions that don't
> have these problems. That is:
>
> error = xfs_sync_inodes(ip->i_mount, SYNC_DELWRI|SYNC_WAIT);
>
> will do a blocking flush of all the inodes without deadlocks occurring.
> Then you can remove the 500ms wait.
I've given this a try with Eric's testcase from #724 in the oss bugzilla,
but it's not enough yet. I thinks that's because SYNC_WAIT is rather
meaningless for data writeout, and we need SYNC_IOWAIT instead. The
patch below gets the testcase working for me:
Index: linux-2.6/fs/xfs/linux-2.6/xfs_sync.c
===================================================================
--- linux-2.6.orig/fs/xfs/linux-2.6/xfs_sync.c 2009-01-22 06:29:30.646141628 +0100
+++ linux-2.6/fs/xfs/linux-2.6/xfs_sync.c 2009-01-22 21:57:53.073864570 +0100
@@ -446,7 +446,9 @@ xfs_flush_device_work(
void *arg)
{
struct inode *inode = arg;
- sync_blockdev(mp->m_super->s_bdev);
+
+ xfs_sync_inodes(mp, SYNC_DELWRI);
+ xfs_sync_inodes(mp, SYNC_DELWRI | SYNC_IOWAIT);
iput(inode);
}
next prev parent reply other threads:[~2009-01-22 20:59 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-12 11:14 spurious -ENOSPC on XFS Mikulas Patocka
2009-01-12 11:14 ` Mikulas Patocka
2009-01-12 15:11 ` Christoph Hellwig
2009-01-12 15:11 ` Christoph Hellwig
2009-01-13 5:58 ` Lachlan McIlroy
2009-01-13 5:58 ` Lachlan McIlroy
2009-01-14 22:16 ` Dave Chinner
2009-01-14 22:16 ` Dave Chinner
2009-01-15 0:57 ` Lachlan McIlroy
2009-01-15 0:57 ` Lachlan McIlroy
2009-01-15 8:47 ` Dave Chinner
2009-01-15 8:47 ` Dave Chinner
2009-01-13 21:49 ` Dave Chinner
2009-01-13 21:49 ` Dave Chinner
2009-01-14 4:28 ` Mikulas Patocka
2009-01-14 4:28 ` Mikulas Patocka
2009-01-18 17:31 ` Christoph Hellwig
2009-01-18 17:31 ` Christoph Hellwig
2009-01-20 19:38 ` Mikulas Patocka
2009-01-20 19:38 ` Mikulas Patocka
2009-01-20 23:24 ` Dave Chinner
2009-01-20 23:24 ` Dave Chinner
2009-01-22 20:59 ` Christoph Hellwig [this message]
2009-01-22 20:59 ` Christoph Hellwig
2009-01-22 22:43 ` Christoph Hellwig
2009-01-22 22:43 ` Christoph Hellwig
2009-01-23 20:14 ` Mikulas Patocka
2009-01-23 20:14 ` Mikulas Patocka
2009-01-24 7:12 ` Dave Chinner
2009-01-24 7:12 ` Dave Chinner
2009-01-29 16:39 ` Mikulas Patocka
2009-01-29 16:39 ` Mikulas Patocka
2009-01-29 16:45 ` Mikulas Patocka
2009-01-29 16:45 ` Mikulas Patocka
2009-01-31 23:57 ` Dave Chinner
2009-01-31 23:57 ` Dave Chinner
2009-02-02 17:36 ` Mikulas Patocka
2009-02-02 17:36 ` Mikulas Patocka
2009-02-03 3:27 ` Dave Chinner
2009-02-03 3:27 ` Dave Chinner
2009-02-03 20:05 ` Mikulas Patocka
2009-02-03 20:05 ` Mikulas Patocka
2009-02-04 12:08 ` Dave Chinner
2009-02-04 12:08 ` Dave Chinner
2009-02-05 4:31 ` Mikulas Patocka
2009-02-05 4:31 ` Mikulas Patocka
2009-02-05 7:43 ` Dave Chinner
2009-02-05 7:43 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090122205913.GA30859@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.