EXTRA_VERSION in #if LINUX_VERSION_CODE >= KERNEL_VERSION(x,x,x)

EXTRA_VERSION in #if LINUX_VERSION_CODE >= KERNEL_VERSION(x,x,x)

[Peter Hallberg]

How does one write stuff like
#if LINUX_VERSION_CODE>= KERNEL_VERSION(2,6,28)
if the 4 digit EXTRA_VERSION also is needed?


_________________________________________________________________
Hitta bästa priserna på MSN Shopping!
http://shopping.msn.se/co_16199-msn-shopping.html

Re: EXTRA_VERSION in #if LINUX_VERSION_CODE >= KERNEL_VERSION(x,x,x)

[Arjan van de Ven]

On Sat, 24 Jan 2009 15:32:06 +0100
Peter Hallberg <hallberg68@hotmail.com> wrote:

> 
> How does one write stuff like
> #if LINUX_VERSION_CODE>= KERNEL_VERSION(2,6,28)
> if the 4 digit EXTRA_VERSION also is needed?u

if you need that something is wrong....

can you be more elaborate in what you're trying to achieve ?

-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org

RE: EXTRA_VERSION in #if LINUX_VERSION_CODE >= KERNEL_VERSION(x,x,x)

[Peter Hallberg]

>> How does one write stuff like
>> #if LINUX_VERSION_CODE>= KERNEL_VERSION(2,6,28)
>> if the 4 digit EXTRA_VERSION also is needed?u
>
> if you need that something is wrong....
>
> can you be more elaborate in what you're trying to achieve ?

Between 2.6.28 and 2.6.28.1 you changed the function grab_cache_page to grab_cache_page_write_begin and added a flags argument. Since I maintain an separate filesystem module I need to take care of this.
>From the change log:
commit 4f093b80fa8facbd22fa36c00242e2fffa36e12f
Author: Nick Piggin 
Date:   Sun Jan 4 12:00:53 2009 -0800

    fs: symlink write_begin allocation context fix
    
    commit 54566b2c1594c2326a645a3551f9d989f7ba3c5e upstream.
Change grab_cache_page to
    accept a nofs argument as well, to honour that flag (while we're there,
    change the name to grab_cache_page_write_begin which is more instructive
    and does away with random leading underscores).


_________________________________________________________________
Hitta bästa priserna på MSN Shopping!
http://shopping.msn.se/co_16199-msn-shopping.html

Re: EXTRA_VERSION in #if LINUX_VERSION_CODE >= KERNEL_VERSION(x,x,x)

[Stefan Richter]

Peter Hallberg wrote:
>>> How does one write stuff like
>>> #if LINUX_VERSION_CODE>= KERNEL_VERSION(2,6,28)
>>> if the 4 digit EXTRA_VERSION also is needed?u
>> if you need that something is wrong....
>>
>> can you be more elaborate in what you're trying to achieve ?
> 
> Between 2.6.28 and 2.6.28.1 you changed the function grab_cache_page
> to grab_cache_page_write_begin and added a flags argument. Since I
> maintain an separate filesystem module I need to take care of this.
> From the change log:
...
>     commit 54566b2c1594c2326a645a3551f9d989f7ba3c5e upstream.

There is a simple trick.  Have a look at that commit.  It adds
#define AOP_FLAG_NOFS			0x0004
to <linux/fs.h>.  You could check for it with #ifdef.

Or you could choose to not support 2.6.28, only 2.6.28.y.
-- 
Stefan Richter
-=====-==--= ---= ==---
http://arcgraph.de/sr/

Re: EXTRA_VERSION in #if LINUX_VERSION_CODE >= KERNEL_VERSION(x,x,x)

[Stefan Richter]

Stefan Richter wrote:
> Peter Hallberg wrote:
>> Since I maintain an separate filesystem module
...
> #define AOP_FLAG_NOFS			0x0004
> to <linux/fs.h>.  You could check for it with #ifdef.

(Don't understand this as general encouragement to maintain stuff
outside the mainline...)
-- 
Stefan Richter
-=====-==--= ---= ==---
http://arcgraph.de/sr/