All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stuart Brady <sdbrady@ntlworld.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [6380] Make make output quieter (Avi Kivity)
Date: Sat, 24 Jan 2009 15:10:35 +0000	[thread overview]
Message-ID: <20090124151035.GA29283@miranda.arrow> (raw)
In-Reply-To: <E1LPhZd-0002lW-DL@cvs.savannah.gnu.org>

On Wed, Jan 21, 2009 at 06:13:09PM +0000, Anthony Liguori wrote:
> Spew out less noise when compiling.  This helps review make output for
> information such as compilation warnings, rather than extra long compiler
> invocations.
> 
> The full output can be generated by supplying a 'V=1' parameter to make.

Excellent!

However, I would find it helpful to see the name of the target that is
being built.  Something like the following? ...

Signed-off-by: Stuart Brady <stuart.brady@gmail.com>

Index: rules.mak
===================================================================
--- rules.mak	(revision 6417)
+++ rules.mak	(working copy)
@@ -1,19 +1,19 @@
 
 %.o: %.c
-	$(call quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@ $<,CC $@)
+	$(call quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@ $<,CC $(TARGET_DIR) $@)
 
 %.o: %.S
-	$(call quiet-command,$(CC) $(CPPFLAGS) -c -o $@ $<,AS $@)
+	$(call quiet-command,$(CC) $(CPPFLAGS) -c -o $@ $<,AS $(TARGET_DIR) $@)
 
 %.o: %.m
-	$(call quiet-command,$(CC) $(CFLAGS) $(CPPFLAGS) -c -o $@ $<,OBJC $@)
+	$(call quiet-command,$(CC) $(CFLAGS) $(CPPFLAGS) -c -o $@ $<,OBJC $(TARGET_DIR) $@)
 
-LINK = $(call quiet-command,$(CC) $(LDFLAGS) -o $@ $^ $(LIBS),LINK $@)
+LINK = $(call quiet-command,$(CC) $(LDFLAGS) -o $@ $^ $(LIBS),LINK $(TARGET_DIR) $@)
 
 %$(EXESUF): %.o
 	$(LINK)
 
 %.a:
-	$(call quiet-command,rm -f $@ && $(AR) rcs $@ $^,AR $@)
+	$(call quiet-command,rm -f $@ && $(AR) rcs $@ $^,AR $(TARGET_DIR) $@)
 
 quiet-command = $(if $(V),$1,@echo $2 && $1)
Index: Makefile
===================================================================
--- Makefile	(revision 6417)
+++ Makefile	(working copy)
@@ -8,6 +8,7 @@
 
 VPATH=$(SRC_PATH):$(SRC_PATH)/hw
 
+TARGET_DIR=common
 
 CFLAGS += $(OS_CFLAGS) $(ARCH_CFLAGS)
 LDFLAGS += $(OS_LDFLAGS) $(ARCH_LDFLAGS)
@@ -39,7 +40,7 @@
 SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_DIRS))
 
 subdir-%:
-	$(MAKE) -C $(subst subdir-,,$@) V="$(V)" all
+	$(MAKE) -C $(subst subdir-,,$@) V="$(V)" TARGET_DIR="$*" all
 
 $(filter %-softmmu,$(SUBDIR_RULES)): libqemu_common.a
 $(filter %-user,$(SUBDIR_RULES)): libqemu_user.a

Or is there a cleaner way of doing this?

(BTW, could the $(subst subdir-,,$@) just be replaced with $*?)

Cheers,
-- 
Stuart Brady

  reply	other threads:[~2009-01-24 15:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-21 18:13 [Qemu-devel] [6380] Make make output quieter (Avi Kivity) Anthony Liguori
2009-01-24 15:10 ` Stuart Brady [this message]
2009-01-25 15:53   ` [Qemu-devel] [PATCH] build system: Further improve quiet mode (was: Re: [6380] Make make output quieter (Avi Kivity)) Jan Kiszka
2009-01-25 15:56     ` Laurent Desnogues
2009-01-25 16:30       ` [Qemu-devel] Re: [PATCH] build system: Further improve quiet mode Jan Kiszka
2009-01-25 16:39         ` Laurent Desnogues
2009-01-26 17:36         ` Anthony Liguori
2009-01-26 18:58           ` Lionel Landwerlin
2009-01-26 18:58           ` Paul Brook
2009-01-26 19:41             ` Anthony Liguori
2009-01-27  9:23               ` Laurent Desnogues
2009-01-27  9:47                 ` Jan Kiszka
2009-01-27  9:49                   ` Jan Kiszka
2009-01-26 19:04           ` Laurent Desnogues
2009-01-26 17:08     ` [Qemu-devel] " Anthony Liguori
2009-01-26 18:08       ` [Qemu-devel] " Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090124151035.GA29283@miranda.arrow \
    --to=sdbrady@ntlworld.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.