From: Jan Kiszka <jan.kiszka@siemens.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] build system: Further improve quiet mode
Date: Tue, 27 Jan 2009 10:47:21 +0100 [thread overview]
Message-ID: <497ED829.1070906@siemens.com> (raw)
In-Reply-To: <761ea48b0901270123x211444d2k224c21ba6df1324b@mail.gmail.com>
Laurent Desnogues wrote:
> On Mon, Jan 26, 2009 at 8:41 PM, Anthony Liguori <anthony@codemonkey.ws> wrote:
>> Paul Brook wrote:
>>>> BTW, what do people think of printing CFLAGS? I find it not all that
>>>> exciting but if people like it, I'm happy to go with it.
>>>>
>>> I don't find it that interesting either. Especially given we use at least
>>> two different sets of CFLAGS, and you really also need to know which
>>> compiler is being invoked. You can always use V=1.
>>>
>> That was my thinking too. The more noise in the build output, the less
>> useful the quiet mode is wrt catching warnings.
>
> So what about this?
>
>
> Laurent
>
> - Make user-mode build process quieter.
>
> Signed-off-by: Laurent Desnogues <laurent.desnogues@gmail.com>
>
> Index: Makefile.target
> ===================================================================
> --- Makefile.target (revision 6463)
> +++ Makefile.target (working copy)
> @@ -725,9 +725,9 @@
> endif # !CONFIG_USER_ONLY
>
> gdbstub-xml.c: $(TARGET_XML_FILES) feature_to_c.sh
> - rm -f $@
> + $(call quiet-command,rm -f $@)
> ifeq ($(TARGET_XML_FILES),)
> - echo > $@
> + $(call quiet-command,echo > $@)
> else
> $(SHELL) $(SRC_PATH)/feature_to_c.sh $@ $(TARGET_XML_FILES)
> endif
I was thinking in this direction already as well. But please go for a
canonical output, something like
GENERATE ppc-softmmu/gdbstub-xml.c
(Likely requires adjusting indention of the other rules.)
Jan
--
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2009-01-27 9:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 18:13 [Qemu-devel] [6380] Make make output quieter (Avi Kivity) Anthony Liguori
2009-01-24 15:10 ` Stuart Brady
2009-01-25 15:53 ` [Qemu-devel] [PATCH] build system: Further improve quiet mode (was: Re: [6380] Make make output quieter (Avi Kivity)) Jan Kiszka
2009-01-25 15:56 ` Laurent Desnogues
2009-01-25 16:30 ` [Qemu-devel] Re: [PATCH] build system: Further improve quiet mode Jan Kiszka
2009-01-25 16:39 ` Laurent Desnogues
2009-01-26 17:36 ` Anthony Liguori
2009-01-26 18:58 ` Lionel Landwerlin
2009-01-26 18:58 ` Paul Brook
2009-01-26 19:41 ` Anthony Liguori
2009-01-27 9:23 ` Laurent Desnogues
2009-01-27 9:47 ` Jan Kiszka [this message]
2009-01-27 9:49 ` Jan Kiszka
2009-01-26 19:04 ` Laurent Desnogues
2009-01-26 17:08 ` [Qemu-devel] " Anthony Liguori
2009-01-26 18:08 ` [Qemu-devel] " Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=497ED829.1070906@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.