All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	David Miller <davem@davemloft.net>,
	mingo@elte.hu, x86@kernel.org, linux-kernel@vger.kernel.org,
	Sam Ravnborg <sam@ravnborg.org>
Subject: Re: Confusion in usr/include/asm-generic/fcntl.h
Date: Mon, 26 Jan 2009 16:53:32 +0100	[thread overview]
Message-ID: <200901261653.32856.arnd@arndb.de> (raw)
In-Reply-To: <1232723900.3504.4.camel@localhost.localdomain>

On Friday 23 January 2009, Jaswinder Singh Rajput wrote:
> 
> So who wins the race for CONFIG_64BIT and will be right candidate for
> usr/include/asm-generic/fcntl.h:
> 
> 1. #if BITS_PER_LONG == 64

namespace pollution => doesn't work

> OR
> 
> 2. #if __BITS_PER_LONG == 64

my suggestion, looks good

> 
> OR
> 
> 3. #ifdef __LP64__

Should work, but not sure if all compilers get it right

> 
> OR
> 
> 4. #if __SIZEOF_POINTER__ == 8

Never heard of this, but seems fine, probably __SIZEOF_LONG__
would be more logical (but with identical results)

> 
> OR
> 
> 5. #if LONG_MAX > 2147483647L

requires #include <stdint.h>, which pollutes the namespace => doesn't work


> OR
> 
> 6. #ifdef __64BIT

Dangerous, as explained.

	Arnd <><

  reply	other threads:[~2009-01-26 15:54 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-21  0:04 Confusion in usr/include/asm-generic/fcntl.h Jaswinder Singh Rajput
2009-01-21  0:16 ` David Miller
2009-01-21  0:24   ` Arnd Bergmann
2009-01-21  0:32     ` David Miller
2009-01-21  8:13       ` Helge Deller
2009-01-21  8:24         ` Arnd Bergmann
2009-01-21 11:38           ` Sam Ravnborg
2009-01-21 12:13             ` Arnd Bergmann
2009-01-21 12:13               ` Arnd Bergmann
2009-01-21 14:29               ` Kyle McMartin
2009-01-21 14:29                 ` Kyle McMartin
2009-01-21 16:44               ` H. Peter Anvin
2009-01-21 17:28               ` Sam Ravnborg
2009-01-21 17:28                 ` Sam Ravnborg
2009-01-21 17:57                 ` H. Peter Anvin
2009-01-27 22:35           ` Helge Deller
2009-01-21 22:25     ` Grant Grundler
2009-01-21 22:43       ` John David Anglin
2009-01-22  0:46         ` H. Peter Anvin
2009-01-22  2:52           ` John David Anglin
2009-01-22  2:56             ` H. Peter Anvin
2009-01-21  0:48   ` H. Peter Anvin
2009-01-21  1:47     ` H. Peter Anvin
2009-01-23 15:18     ` Jaswinder Singh Rajput
2009-01-26 15:53       ` Arnd Bergmann [this message]
2009-01-26 16:24         ` Jaswinder Singh Rajput

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200901261653.32856.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=hpa@zytor.com \
    --cc=jaswinder@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=sam@ravnborg.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.