All of lore.kernel.org
 help / color / mirror / Atom feed
From: Folkert van Heusden <folkert@vanheusden.com>
To: Oliver Neukum <oliver@neukum.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: 2.6.29rc1 breakes usb: hiddev device no longer available
Date: Tue, 27 Jan 2009 20:52:30 +0100	[thread overview]
Message-ID: <20090127195229.GA6158@vanheusden.com> (raw)
In-Reply-To: <200901262005.08168.oliver@neukum.org>

> > > Since version 2.6.29rc1 querying cleware USb devices no longer works.
> > > 2.6.28 works fine. 2.6.29-rc2 also no longer works.
> > 
> 
> > the is the FAILURE situation (2.6.29-rc*):
> > open("/dev/usb/hiddev0", O_RDWR)        = 3
> > ioctl(3, HIDIOCGDEVINFO, 0xbf90c0d8)    = 0
> > ioctl(3, HIDIOCAPPLICATION, 0)          = -6291455
> > ioctl(3, HIDIOCGSTRING, 0x804e2c0)      = -1 ENODEV (No such device)
> Please try this patch.

Yes, that fixes it! Thanks!


Ack-by: folkert@vanheusden.com

> --- linux-2.6/drivers/hid/usbhid/hiddev.c.alt	2009-01-26 20:03:10.000000000 +0100
> +++ linux-2.6/drivers/hid/usbhid/hiddev.c	2009-01-26 20:03:17.000000000 +0100
> @@ -656,7 +656,7 @@ static long hiddev_ioctl(struct file *fi
>  
>  	case HIDIOCGSTRING:
>  		mutex_lock(&hiddev->existancelock);
> -		if (!hiddev->exist)
> +		if (hiddev->exist)
>  			r = hiddev_ioctl_string(hiddev, cmd, user_arg);
>  		else
>  			r = -ENODEV;


Folkert van Heusden

-- 
MultiTail è uno flexible tool per seguire di logfiles e effettuazione
di commissioni. Feltrare, provedere da colore, merge, 'diff-view',
etc. http://www.vanheusden.com/multitail/
----------------------------------------------------------------------
Phone: +31-6-41278122, PGP-key: 1F28D8AE, www.vanheusden.com
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Folkert van Heusden <folkert@vanheusden.com>
To: Oliver Neukum <oliver@neukum.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: 2.6.29rc1 breakes usb: hiddev device no longer available
Date: Tue, 27 Jan 2009 20:52:30 +0100	[thread overview]
Message-ID: <20090127195229.GA6158@vanheusden.com> (raw)
In-Reply-To: <200901262005.08168.oliver@neukum.org>

> > > Since version 2.6.29rc1 querying cleware USb devices no longer works.
> > > 2.6.28 works fine. 2.6.29-rc2 also no longer works.
> > 
> 
> > the is the FAILURE situation (2.6.29-rc*):
> > open("/dev/usb/hiddev0", O_RDWR)        = 3
> > ioctl(3, HIDIOCGDEVINFO, 0xbf90c0d8)    = 0
> > ioctl(3, HIDIOCAPPLICATION, 0)          = -6291455
> > ioctl(3, HIDIOCGSTRING, 0x804e2c0)      = -1 ENODEV (No such device)
> Please try this patch.

Yes, that fixes it! Thanks!


Ack-by: folkert@vanheusden.com

> --- linux-2.6/drivers/hid/usbhid/hiddev.c.alt	2009-01-26 20:03:10.000000000 +0100
> +++ linux-2.6/drivers/hid/usbhid/hiddev.c	2009-01-26 20:03:17.000000000 +0100
> @@ -656,7 +656,7 @@ static long hiddev_ioctl(struct file *fi
>  
>  	case HIDIOCGSTRING:
>  		mutex_lock(&hiddev->existancelock);
> -		if (!hiddev->exist)
> +		if (hiddev->exist)
>  			r = hiddev_ioctl_string(hiddev, cmd, user_arg);
>  		else
>  			r = -ENODEV;


Folkert van Heusden

-- 
MultiTail è uno flexible tool per seguire di logfiles e effettuazione
di commissioni. Feltrare, provedere da colore, merge, 'diff-view',
etc. http://www.vanheusden.com/multitail/
----------------------------------------------------------------------
Phone: +31-6-41278122, PGP-key: 1F28D8AE, www.vanheusden.com

  reply	other threads:[~2009-01-27 19:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-26 17:01 2.6.29rc1 brakes usb Folkert van Heusden
2009-01-26 18:27 ` 2.6.29rc1 breakes usb: hiddev device no longer available Folkert van Heusden
2009-01-26 19:05   ` Oliver Neukum
2009-01-27 19:52     ` Folkert van Heusden [this message]
2009-01-27 19:52       ` Folkert van Heusden
2009-02-02 12:33       ` Jiri Kosina
2009-01-26 19:11 ` 2.6.29rc1 brakes usb Oliver Neukum
2009-01-27 19:55   ` Folkert van Heusden
2009-01-27 21:04     ` Oliver Neukum
2009-01-27 21:05       ` Folkert van Heusden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090127195229.GA6158@vanheusden.com \
    --to=folkert@vanheusden.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oliver@neukum.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.