2.6.29-rc: remaining regression: n770_defconfig, omap_apollon_2420_defconfig

2.6.29-rc: remaining regression: n770_defconfig, omap_apollon_2420_defconfig

[Russell King - ARM Linux]

Now that the usb_port_suspend() build error is fixed in 2.6.29-rc1-git6,
n770_defconfig and omap_apollon_2420_defconfig now suffers from:

drivers/built-in.o: In function `ohci_omap_init':
hid-quirks.c:(.text+0x6c620): undefined reference to `otg_get_transceiver'
drivers/built-in.o: In function `omap_udc_probe':
hid-quirks.c:(.init.text+0x34c0): undefined reference to `otg_get_transceiver'
hid-quirks.c:(.init.text+0x3d40): undefined reference to `otg_put_transceiver'

Re: 2.6.29-rc: remaining regression: n770_defconfig, omap_apollon_2420_defconfig

[Tony Lindgren]

* Russell King - ARM Linux <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org> [090127 14:50]:
> Now that the usb_port_suspend() build error is fixed in 2.6.29-rc1-git6,
> n770_defconfig and omap_apollon_2420_defconfig now suffers from:
> 
> drivers/built-in.o: In function `ohci_omap_init':
> hid-quirks.c:(.text+0x6c620): undefined reference to `otg_get_transceiver'
> drivers/built-in.o: In function `omap_udc_probe':
> hid-quirks.c:(.init.text+0x34c0): undefined reference to `otg_get_transceiver'
> hid-quirks.c:(.init.text+0x3d40): undefined reference to `otg_put_transceiver'

Adding linux-usb to the list hoping there's already a fix for this.

To me it looks like there should be ifdef CONFIG_USB_OTG_UTILS instead
of CONFIG_USB_OTG in the drivers to keep them compiling when no
transceiver is selected.

Or otg.h should have inlined dummy functions for otg_get_transceiver
and otg_put_transceiver.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: 2.6.29-rc: remaining regression: n770_defconfig, omap_apollon_2420_defconfig

[David Brownell]

On Tuesday 27 January 2009, Tony Lindgren wrote:
> * Russell King - ARM Linux <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org> [090127 14:50]:
> > Now that the usb_port_suspend() build error is fixed in 2.6.29-rc1-git6,
> > n770_defconfig and omap_apollon_2420_defconfig now suffers from:
> > 
> > drivers/built-in.o: In function `ohci_omap_init':
> > hid-quirks.c:(.text+0x6c620): undefined reference to `otg_get_transceiver'
> > drivers/built-in.o: In function `omap_udc_probe':
> > hid-quirks.c:(.init.text+0x34c0): undefined reference to `otg_get_transceiver'
> > hid-quirks.c:(.init.text+0x3d40): undefined reference to `otg_put_transceiver'
> 
> Adding linux-usb to the list hoping there's already a fix for this.

Scheduled for 2.6.29-soon:

http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6
	/gregkh-02-usb.current/usb-omap1-ohci-buildfix.patch



--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: 2.6.29-rc: remaining regression: n770_defconfig, omap_apollon_2420_defconfig

[Kyungmin Park]

Hi,

On Wed, Jan 28, 2009 at 8:45 AM, David Brownell <david-b@pacbell.net> wrote:
> On Tuesday 27 January 2009, Tony Lindgren wrote:
>> * Russell King - ARM Linux <linux@arm.linux.org.uk> [090127 14:50]:
>> > Now that the usb_port_suspend() build error is fixed in 2.6.29-rc1-git6,
>> > n770_defconfig and omap_apollon_2420_defconfig now suffers from:
>> >
>> > drivers/built-in.o: In function `ohci_omap_init':
>> > hid-quirks.c:(.text+0x6c620): undefined reference to `otg_get_transceiver'
>> > drivers/built-in.o: In function `omap_udc_probe':
>> > hid-quirks.c:(.init.text+0x34c0): undefined reference to `otg_get_transceiver'
>> > hid-quirks.c:(.init.text+0x3d40): undefined reference to `otg_put_transceiver'
>>
>> Adding linux-usb to the list hoping there's already a fix for this.
>
> Scheduled for 2.6.29-soon:
>
> http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6
>        /gregkh-02-usb.current/usb-omap1-ohci-buildfix.patch
>

Also need following patch in case of usb gadget only.

Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
index 3219d13..b26d6e6 100644
--- a/drivers/usb/gadget/Kconfig
+++ b/drivers/usb/gadget/Kconfig
@@ -191,6 +191,7 @@ config USB_GADGET_OMAP
 	boolean "OMAP USB Device Controller"
 	depends on ARCH_OMAP
 	select ISP1301_OMAP if MACH_OMAP_H2 || MACH_OMAP_H3 || MACH_OMAP_H4_OTG
+	select USB_OTG_UTILS if ARCH_OMAP
 	help
 	   Many Texas Instruments OMAP processors have flexible full
 	   speed USB device controllers, with support for up to 30