[PATCH] ide/net: flip the order of SATA and network init

[PATCH] ide/net: flip the order of SATA and network init

[Arjan van de Ven]

>From e89d6840ad685a3c61f72367d4ac5bfed69ead0c Mon Sep 17 00:00:00 2001
From: Arjan van de Ven <arjan@linux.intel.com>
Date: Mon, 26 Jan 2009 18:58:11 -0800
Subject: [PATCH] ide/net: flip the order of SATA and network init

this patch flips the order in which sata and network drivers are initialized.

SATA probing takes quite a bit of time, and with the asynchronous infrastructure
other drivers that run after it can execute in parallel. Network drivers do tend
to take some real time talking to the hardware, so running these later is
a good thing (the sata probe then runs concurrent)

This saves about 15% of my kernels boot time.

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
---
 drivers/Makefile |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/Makefile b/drivers/Makefile
index c1bf417..2618a61 100644
--- a/drivers/Makefile
+++ b/drivers/Makefile
@@ -36,13 +36,14 @@ obj-$(CONFIG_FB_INTEL)          += video/intelfb/
 
 obj-y				+= serial/
 obj-$(CONFIG_PARPORT)		+= parport/
-obj-y				+= base/ block/ misc/ mfd/ net/ media/
+obj-y				+= base/ block/ misc/ mfd/ media/
 obj-$(CONFIG_NUBUS)		+= nubus/
-obj-$(CONFIG_ATM)		+= atm/
 obj-y				+= macintosh/
 obj-$(CONFIG_IDE)		+= ide/
 obj-$(CONFIG_SCSI)		+= scsi/
 obj-$(CONFIG_ATA)		+= ata/
+obj-y				+= net/
+obj-$(CONFIG_ATM)		+= atm/
 obj-$(CONFIG_FUSION)		+= message/
 obj-$(CONFIG_FIREWIRE)		+= firewire/
 obj-y				+= ieee1394/
-- 
1.6.0.5



-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org

Re: [PATCH] ide/net: flip the order of SATA and network init

[David Miller]

From: Arjan van de Ven <arjan@infradead.org>
Date: Tue, 27 Jan 2009 14:19:52 -0800

> ide/net: flip the order of SATA and network init
> 
> this patch flips the order in which sata and network drivers are initialized.
> 
> SATA probing takes quite a bit of time, and with the asynchronous infrastructure
> other drivers that run after it can execute in parallel. Network drivers do tend
> to take some real time talking to the hardware, so running these later is
> a good thing (the sata probe then runs concurrent)
> 
> This saves about 15% of my kernels boot time.
> 
> Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>

I have no problem with this:

Acked-by: David S. Miller <davem@davemloft.net>

Re: [PATCH] ide/net: flip the order of SATA and network init

[Jeff Garzik]

Arjan van de Ven wrote:
>>From e89d6840ad685a3c61f72367d4ac5bfed69ead0c Mon Sep 17 00:00:00 2001
> From: Arjan van de Ven <arjan@linux.intel.com>
> Date: Mon, 26 Jan 2009 18:58:11 -0800
> Subject: [PATCH] ide/net: flip the order of SATA and network init
> 
> this patch flips the order in which sata and network drivers are initialized.
> 
> SATA probing takes quite a bit of time, and with the asynchronous infrastructure
> other drivers that run after it can execute in parallel. Network drivers do tend
> to take some real time talking to the hardware, so running these later is
> a good thing (the sata probe then runs concurrent)
> 
> This saves about 15% of my kernels boot time.
> 
> Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
> ---
>  drivers/Makefile |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/Makefile b/drivers/Makefile
> index c1bf417..2618a61 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -36,13 +36,14 @@ obj-$(CONFIG_FB_INTEL)          += video/intelfb/
>  
>  obj-y				+= serial/
>  obj-$(CONFIG_PARPORT)		+= parport/
> -obj-y				+= base/ block/ misc/ mfd/ net/ media/
> +obj-y				+= base/ block/ misc/ mfd/ media/
>  obj-$(CONFIG_NUBUS)		+= nubus/
> -obj-$(CONFIG_ATM)		+= atm/
>  obj-y				+= macintosh/
>  obj-$(CONFIG_IDE)		+= ide/
>  obj-$(CONFIG_SCSI)		+= scsi/
>  obj-$(CONFIG_ATA)		+= ata/
> +obj-y				+= net/
> +obj-$(CONFIG_ATM)		+= atm/
>  obj-$(CONFIG_FUSION)		+= message/
>  obj-$(CONFIG_FIREWIRE)		+= firewire/
>  obj-y				+= ieee1394/

ACK, ok with me too

Re: [PATCH] ide/net: flip the order of SATA and network init

[Arjan van de Ven]

On Tue, 27 Jan 2009 18:35:37 -0500
Jeff Garzik <jeff@garzik.org> wrote:

> ACK, ok with me too
> 

ok so... which tree should this go via?

I would guess jgarzik's because he deals with both sata and net ;)

Jeff... how do you want to handle this?

-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org

Re: [PATCH] ide/net: flip the order of SATA and network init

[David Miller]

From: Arjan van de Ven <arjan@infradead.org>
Date: Tue, 27 Jan 2009 16:48:42 -0800

> On Tue, 27 Jan 2009 18:35:37 -0500
> Jeff Garzik <jeff@garzik.org> wrote:
> 
> > ACK, ok with me too
> > 
> 
> ok so... which tree should this go via?

Feel free to just submit it directly to Linus, you have both
of our ACKs :-)

Re: [PATCH] ide/net: flip the order of SATA and network init

[Jeff Garzik]

David Miller wrote:
> From: Arjan van de Ven <arjan@infradead.org>
> Date: Tue, 27 Jan 2009 16:48:42 -0800
> 
>> On Tue, 27 Jan 2009 18:35:37 -0500
>> Jeff Garzik <jeff@garzik.org> wrote:
>>
>>> ACK, ok with me too
>>>
>> ok so... which tree should this go via?
> 
> Feel free to just submit it directly to Linus, you have both
> of our ACKs :-)

ACK :)

Re: [PATCH] ide/net: flip the order of SATA and network init

[Bartlomiej Zolnierkiewicz]

On Tuesday 27 January 2009, Arjan van de Ven wrote:
> From e89d6840ad685a3c61f72367d4ac5bfed69ead0c Mon Sep 17 00:00:00 2001
> From: Arjan van de Ven <arjan@linux.intel.com>
> Date: Mon, 26 Jan 2009 18:58:11 -0800
> Subject: [PATCH] ide/net: flip the order of SATA and network init
> 
> this patch flips the order in which sata and network drivers are initialized.

it seems to affect much more than that, please see below

> SATA probing takes quite a bit of time, and with the asynchronous infrastructure
> other drivers that run after it can execute in parallel. Network drivers do tend
> to take some real time talking to the hardware, so running these later is
> a good thing (the sata probe then runs concurrent)
> 
> This saves about 15% of my kernels boot time.
> 
> Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
> ---
>  drivers/Makefile |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/Makefile b/drivers/Makefile
> index c1bf417..2618a61 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -36,13 +36,14 @@ obj-$(CONFIG_FB_INTEL)          += video/intelfb/
>  
>  obj-y				+= serial/
>  obj-$(CONFIG_PARPORT)		+= parport/
> -obj-y				+= base/ block/ misc/ mfd/ net/ media/
> +obj-y				+= base/ block/ misc/ mfd/ media/
>  obj-$(CONFIG_NUBUS)		+= nubus/
> -obj-$(CONFIG_ATM)		+= atm/
>  obj-y				+= macintosh/
>  obj-$(CONFIG_IDE)		+= ide/
>  obj-$(CONFIG_SCSI)		+= scsi/

scsi, ide, macintosh and nubus will be now init-ed after network.

No problem for ide but I'm not really sure about scsi...

>  obj-$(CONFIG_ATA)		+= ata/
> +obj-y				+= net/
> +obj-$(CONFIG_ATM)		+= atm/
>  obj-$(CONFIG_FUSION)		+= message/
>  obj-$(CONFIG_FIREWIRE)		+= firewire/
>  obj-y				+= ieee1394/

[2.6.30] What's in the async boot tree

[Arjan van de Ven]

The following changes since commit 326d8519fc97be186c55ac605c3a7c957c758ae1:
  Linus Torvalds (1):
        Merge branch 'upstream' of git://ftp.linux-mips.org/pub/scm/upstream-linus

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/arjan/linux-2.6-async-for-30.git master

Arjan van de Ven (2):
      async: remove the temporary (2.6.29) "async is off by default" code
      ide/net: flip the order of SATA and network init

Li, Shaohua (1):
      fastboot: remove duplicate unpack_to_rootfs()

 drivers/Makefile |    5 ++-
 init/initramfs.c |   71 ++++++++++++++++++++++++++++++++++++++++++-----------
 kernel/async.c   |   10 +-------
 3 files changed, 60 insertions(+), 26 deletions(-)


I will reply to this email with the three patches


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org

[PATCH] ide/net: flip the order of SATA and network init

[Arjan van de Ven]

>From 7c73393acfcce11a8d8ee661e08bae24fc17af61 Mon Sep 17 00:00:00 2001
From: Arjan van de Ven <arjan@linux.intel.com>
Date: Mon, 26 Jan 2009 18:58:11 -0800
Subject: [PATCH] ide/net: flip the order of SATA and network init

this patch flips the order in which sata and network drivers are initialized.

SATA probing takes quite a bit of time, and with the asynchronous infrastructure
other drivers that run after it can execute in parallel. Network drivers do tend
to take some real time talking to the hardware, so running these later is
a good thing (the sata probe then runs concurrent)

This saves about 15% of my kernels boot time.

Both Dave and Jeff acked this patch and suggested it should go via the async
tree.

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Acked-by: David S. Miller <davem@davemloft.net>
Acked-by: Jeff Garzik <jeff@garzik.org>
---
 drivers/Makefile |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/Makefile b/drivers/Makefile
index c1bf417..2618a61 100644
--- a/drivers/Makefile
+++ b/drivers/Makefile
@@ -36,13 +36,14 @@ obj-$(CONFIG_FB_INTEL)          += video/intelfb/
 
 obj-y				+= serial/
 obj-$(CONFIG_PARPORT)		+= parport/
-obj-y				+= base/ block/ misc/ mfd/ net/ media/
+obj-y				+= base/ block/ misc/ mfd/ media/
 obj-$(CONFIG_NUBUS)		+= nubus/
-obj-$(CONFIG_ATM)		+= atm/
 obj-y				+= macintosh/
 obj-$(CONFIG_IDE)		+= ide/
 obj-$(CONFIG_SCSI)		+= scsi/
 obj-$(CONFIG_ATA)		+= ata/
+obj-y				+= net/
+obj-$(CONFIG_ATM)		+= atm/
 obj-$(CONFIG_FUSION)		+= message/
 obj-$(CONFIG_FIREWIRE)		+= firewire/
 obj-y				+= ieee1394/
-- 
1.6.0.6




-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org