* [patch]reversed logic in disconnect testing of hiddev
@ 2009-01-28 8:30 Oliver Neukum
2009-01-28 8:38 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Oliver Neukum @ 2009-01-28 8:30 UTC (permalink / raw)
To: Jiri Kosina, linux-input
The logic for testing for disconnection is reversed in an ioctl leading
to false reports of disconnection.
Signed-off-by: Oliver Neukum <oneukum@suse.de>
Tested-by: Folkert van Heusden <folkert@vanheusden.com>
Hi,
this should go into the next rc of 2.6.29
Regards
Oliver
---
--- linux-2.6/drivers/hid/usbhid/hiddev.c.alt 2009-01-26 20:03:10.000000000 +0100
+++ linux-2.6/drivers/hid/usbhid/hiddev.c 2009-01-26 20:03:17.000000000 +0100
@@ -656,7 +656,7 @@ static long hiddev_ioctl(struct file *fi
case HIDIOCGSTRING:
mutex_lock(&hiddev->existancelock);
- if (!hiddev->exist)
+ if (hiddev->exist)
r = hiddev_ioctl_string(hiddev, cmd, user_arg);
else
r = -ENODEV;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch]reversed logic in disconnect testing of hiddev
2009-01-28 8:30 [patch]reversed logic in disconnect testing of hiddev Oliver Neukum
@ 2009-01-28 8:38 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2009-01-28 8:38 UTC (permalink / raw)
To: Oliver Neukum; +Cc: linux-input
On Wed, 28 Jan 2009, Oliver Neukum wrote:
> The logic for testing for disconnection is reversed in an ioctl leading
> to false reports of disconnection.
>
> Signed-off-by: Oliver Neukum <oneukum@suse.de>
> Tested-by: Folkert van Heusden <folkert@vanheusden.com>
>
> this should go into the next rc of 2.6.29
Applied, thanks Oliver.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-28 8:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-28 8:30 [patch]reversed logic in disconnect testing of hiddev Oliver Neukum
2009-01-28 8:38 ` Jiri Kosina
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.