* [PATCH] trace: Use tracing_reset_online_cpus in more places
@ 2009-01-28 15:02 Arnaldo Carvalho de Melo
2009-01-28 15:06 ` Frédéric Weisbecker
0 siblings, 1 reply; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2009-01-28 15:02 UTC (permalink / raw)
To: Steven Rostedt
Cc: Frédéric Weisbecker, Ingo Molnar,
Linux Kernel Mailing List
Impact: cleanup
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
diff --git a/kernel/trace/trace_branch.c b/kernel/trace/trace_branch.c
index ca017e0..1284145 100644
--- a/kernel/trace/trace_branch.c
+++ b/kernel/trace/trace_branch.c
@@ -133,11 +133,7 @@ static void stop_branch_trace(struct trace_array *tr)
static int branch_trace_init(struct trace_array *tr)
{
- int cpu;
-
- for_each_online_cpu(cpu)
- tracing_reset(tr, cpu);
-
+ tracing_reset_online_cpus(tr);
start_branch_trace(tr);
return 0;
}
diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c
index 66fc7b8..c97594d 100644
--- a/kernel/trace/trace_functions_graph.c
+++ b/kernel/trace/trace_functions_graph.c
@@ -52,15 +52,11 @@ static struct tracer_flags tracer_flags = {
static int graph_trace_init(struct trace_array *tr)
{
- int cpu, ret;
-
- for_each_online_cpu(cpu)
- tracing_reset(tr, cpu);
-
- ret = register_ftrace_graph(&trace_graph_return,
+ int ret = register_ftrace_graph(&trace_graph_return,
&trace_graph_entry);
if (ret)
return ret;
+ tracing_reset_online_cpus(tr);
tracing_start_cmdline_record();
return 0;
diff --git a/kernel/trace/trace_nop.c b/kernel/trace/trace_nop.c
index b9767ac..087b6cb 100644
--- a/kernel/trace/trace_nop.c
+++ b/kernel/trace/trace_nop.c
@@ -47,12 +47,8 @@ static void stop_nop_trace(struct trace_array *tr)
static int nop_trace_init(struct trace_array *tr)
{
- int cpu;
ctx_trace = tr;
-
- for_each_online_cpu(cpu)
- tracing_reset(tr, cpu);
-
+ tracing_reset_online_cpus(tr);
start_nop_trace(tr);
return 0;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] trace: Use tracing_reset_online_cpus in more places
2009-01-28 15:02 [PATCH] trace: Use tracing_reset_online_cpus in more places Arnaldo Carvalho de Melo
@ 2009-01-28 15:06 ` Frédéric Weisbecker
2009-01-29 13:29 ` Ingo Molnar
0 siblings, 1 reply; 3+ messages in thread
From: Frédéric Weisbecker @ 2009-01-28 15:06 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo, Steven Rostedt,
Frédéric Weisbecker, Ingo Molnar,
Linux Kernel Mailing List
2009/1/28 Arnaldo Carvalho de Melo <acme@ghostprotocols.net>:
> Impact: cleanup
>
> Cc: Frédéric Weisbecker <fweisbec@gmail.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> diff --git a/kernel/trace/trace_branch.c b/kernel/trace/trace_branch.c
> index ca017e0..1284145 100644
> --- a/kernel/trace/trace_branch.c
> +++ b/kernel/trace/trace_branch.c
> @@ -133,11 +133,7 @@ static void stop_branch_trace(struct trace_array *tr)
>
> static int branch_trace_init(struct trace_array *tr)
> {
> - int cpu;
> -
> - for_each_online_cpu(cpu)
> - tracing_reset(tr, cpu);
> -
> + tracing_reset_online_cpus(tr);
> start_branch_trace(tr);
> return 0;
> }
> diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c
> index 66fc7b8..c97594d 100644
> --- a/kernel/trace/trace_functions_graph.c
> +++ b/kernel/trace/trace_functions_graph.c
> @@ -52,15 +52,11 @@ static struct tracer_flags tracer_flags = {
>
> static int graph_trace_init(struct trace_array *tr)
> {
> - int cpu, ret;
> -
> - for_each_online_cpu(cpu)
> - tracing_reset(tr, cpu);
> -
> - ret = register_ftrace_graph(&trace_graph_return,
> + int ret = register_ftrace_graph(&trace_graph_return,
> &trace_graph_entry);
> if (ret)
> return ret;
> + tracing_reset_online_cpus(tr);
> tracing_start_cmdline_record();
>
> return 0;
> diff --git a/kernel/trace/trace_nop.c b/kernel/trace/trace_nop.c
> index b9767ac..087b6cb 100644
> --- a/kernel/trace/trace_nop.c
> +++ b/kernel/trace/trace_nop.c
> @@ -47,12 +47,8 @@ static void stop_nop_trace(struct trace_array *tr)
>
> static int nop_trace_init(struct trace_array *tr)
> {
> - int cpu;
> ctx_trace = tr;
> -
> - for_each_online_cpu(cpu)
> - tracing_reset(tr, cpu);
> -
> + tracing_reset_online_cpus(tr);
> start_nop_trace(tr);
> return 0;
> }
>
Thanks :-)
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] trace: Use tracing_reset_online_cpus in more places
2009-01-28 15:06 ` Frédéric Weisbecker
@ 2009-01-29 13:29 ` Ingo Molnar
0 siblings, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2009-01-29 13:29 UTC (permalink / raw)
To: Frédéric Weisbecker
Cc: Arnaldo Carvalho de Melo, Steven Rostedt,
Linux Kernel Mailing List
* Frédéric Weisbecker <fweisbec@gmail.com> wrote:
> 2009/1/28 Arnaldo Carvalho de Melo <acme@ghostprotocols.net>:
> > Impact: cleanup
> >
> > Cc: Frédéric Weisbecker <fweisbec@gmail.com>
> > Cc: Steven Rostedt <rostedt@goodmis.org>
> > Cc: Ingo Molnar <mingo@elte.hu>
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> >
> > diff --git a/kernel/trace/trace_branch.c b/kernel/trace/trace_branch.c
> > index ca017e0..1284145 100644
> > --- a/kernel/trace/trace_branch.c
> > +++ b/kernel/trace/trace_branch.c
> > @@ -133,11 +133,7 @@ static void stop_branch_trace(struct trace_array *tr)
> >
> > static int branch_trace_init(struct trace_array *tr)
> > {
> > - int cpu;
> > -
> > - for_each_online_cpu(cpu)
> > - tracing_reset(tr, cpu);
> > -
> > + tracing_reset_online_cpus(tr);
> > start_branch_trace(tr);
> > return 0;
> > }
> > diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c
> > index 66fc7b8..c97594d 100644
> > --- a/kernel/trace/trace_functions_graph.c
> > +++ b/kernel/trace/trace_functions_graph.c
> > @@ -52,15 +52,11 @@ static struct tracer_flags tracer_flags = {
> >
> > static int graph_trace_init(struct trace_array *tr)
> > {
> > - int cpu, ret;
> > -
> > - for_each_online_cpu(cpu)
> > - tracing_reset(tr, cpu);
> > -
> > - ret = register_ftrace_graph(&trace_graph_return,
> > + int ret = register_ftrace_graph(&trace_graph_return,
> > &trace_graph_entry);
> > if (ret)
> > return ret;
> > + tracing_reset_online_cpus(tr);
> > tracing_start_cmdline_record();
> >
> > return 0;
> > diff --git a/kernel/trace/trace_nop.c b/kernel/trace/trace_nop.c
> > index b9767ac..087b6cb 100644
> > --- a/kernel/trace/trace_nop.c
> > +++ b/kernel/trace/trace_nop.c
> > @@ -47,12 +47,8 @@ static void stop_nop_trace(struct trace_array *tr)
> >
> > static int nop_trace_init(struct trace_array *tr)
> > {
> > - int cpu;
> > ctx_trace = tr;
> > -
> > - for_each_online_cpu(cpu)
> > - tracing_reset(tr, cpu);
> > -
> > + tracing_reset_online_cpus(tr);
> > start_nop_trace(tr);
> > return 0;
> > }
> >
>
> Thanks :-)
>
> Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
Applied to tip/tracing/ftrace (with your Ack added), thanks guys!
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-01-29 13:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-28 15:02 [PATCH] trace: Use tracing_reset_online_cpus in more places Arnaldo Carvalho de Melo
2009-01-28 15:06 ` Frédéric Weisbecker
2009-01-29 13:29 ` Ingo Molnar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.