Re: [PATCH] parisc: don't touch driver core internals

[Greg KH <greg@kroah.com>]

On Wed, Jan 28, 2009 at 11:25:19AM -0600, James Bottomley wrote:
> On Mon, 2009-01-26 at 17:07 -0800, Greg KH wrote:
> > From: Greg Kroah-Hartman <gregkh@suse.de>
> > 
> > It isn't wise to use the struct device klists on their own, as their
> > implementation has a tendancy to change at times.  Instead, use the
> > functions created for iterating over lists of devices, as it handles all
> > of the dirty klist work for you automatically.
> > 
> > This is needed as the driver core is changing how klists are stored in
> > struct device in the near future.
> > 
> > Cc: Kyle McMartin <kyle@mcmartin.ca>
> > Cc: Matthew Wilcox <matthew@wil.cx>
> > Cc: Grant Grundler <grundler@parisc-linux.org>
> > Cc: Kay Sievers <kay.sievers@vrfy.org>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> > 
> > ---
> > 
> > I can keep this in my driver-core tree, where is it required in order
> > for parisc to build properly.  Or you all can take this now, in your
> > tree, whatever is easier for you.
> > 
> >  drivers/char/agp/parisc-agp.c |   24 ++++++---------
> >  drivers/parisc/gsc.c          |   40 +++++++++++++++-----------
> >  drivers/parisc/sba_iommu.c    |   64 ++++++++++++++++++++++++------------------
> >  3 files changed, 71 insertions(+), 57 deletions(-)
> 
> Actually, we already have such a patch here:
> 
> http://marc.info/?l=linux-parisc&m=123154903507114
> 
> The approaches look identical.

Author: Greg Kroah-Hartman <gregkh@suse.de>  ???

I wrote that?  heh, I forgot all about that...

Yeah, that looks fine to me.

thanks,

greg k-h