All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fix output of numactl --hardware with >BITS_PER_LONG cpus
@ 2009-01-28 16:41 Arnd Bergmann
  0 siblings, 0 replies; only message in thread
From: Arnd Bergmann @ 2009-01-28 16:41 UTC (permalink / raw)
  To: Cliff Wickman; +Cc: linux-numa, hannsj_uhl, wmb

There was evidently a glitch in the conversion of numactl to libnuma2:

The print_node_cpus function tries to find the size of the bitmask,
which it no longer needs to. This results in printing only the
first word of the CPU mask.

This fixes the function to print all available CPUs again.

Found by Bill Buros on a 128-way 64 bit system.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

diff --git a/numactl.c b/numactl.c
index 2de33d8..f1a7166 100644
--- a/numactl.c
+++ b/numactl.c
@@ -199,28 +199,16 @@ static void print_distances(int maxnode)
 
 void print_node_cpus(int node)
 {
-	int len = 1;
 	int conf_cpus = numa_num_configured_cpus();
+	int i, err;
+	struct bitmask *cpus;
 
-	for (;;) { 
-		int i, err;
-		struct bitmask *cpus;
-
-		cpus = numa_bitmask_alloc(conf_cpus);
-		errno = 0;
-		err = numa_node_to_cpus(node, cpus);
-		if (err < 0) {
-			if (errno == ERANGE) {
-				len *= 2; 
-				continue;
-			}
-			break; 
-		}
-		for (i = 0; i < len*BITS_PER_LONG; i++) 
+	cpus = numa_bitmask_alloc(conf_cpus);
+	err = numa_node_to_cpus(node, cpus);
+	if (err >= 0) 
+		for (i = 0; i < conf_cpus; i++) 
 			if (numa_bitmask_isbitset(cpus, i))
 				printf(" %d", i);
-		break;
-	}
 	putchar('\n');
 }
 

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2009-01-28 16:41 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-28 16:41 [PATCH] fix output of numactl --hardware with >BITS_PER_LONG cpus Arnd Bergmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.