From: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Cc: "David C. Hansen"
<haveblue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org,
Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>,
Alan Cox <alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
Subject: [RFC][PATCH 4/5] Remove get_init_pts_sb()
Date: Wed, 28 Jan 2009 22:47:20 -0800 [thread overview]
Message-ID: <20090129064720.GE23160@us.ibm.com> (raw)
In-Reply-To: <20090129064259.GA23160-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
From: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Date: Wed, 28 Jan 2009 18:59:28 -0800
Subject: [RFC][PATCH 4/5] Remove get_init_pts_sb()
With mknod_ptmx() moved to devpts_get_sb(), init_pts_mount() becomes
a wrapper around get_init_pts_sb(). Remove get_init_pts_sb() and
fold code into init_pts_mount().
Signed-off-by: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
---
fs/devpts/inode.c | 25 ++++++-------------------
1 files changed, 6 insertions(+), 19 deletions(-)
diff --git a/fs/devpts/inode.c b/fs/devpts/inode.c
index 97b8e9f..733e8e0 100644
--- a/fs/devpts/inode.c
+++ b/fs/devpts/inode.c
@@ -347,7 +347,11 @@ static int new_pts_mount(struct file_system_type *fs_type, int flags,
}
/*
- * get_init_pts_sb()
+ * init_pts_mount()
+ *
+ * Mount or remount the initial kernel mount of devpts. This type of
+ * mount maintains the legacy, single-instance semantics, while the
+ * kernel still allows multiple-instances.
*
* This interface is needed to support multiple namespace semantics in
* devpts while preserving backward compatibility of the current 'single-
@@ -367,7 +371,7 @@ static int new_pts_mount(struct file_system_type *fs_type, int flags,
* consistently selects the 'single-namespace' superblock even in the
* presence of the private namespace (i.e 'newinstance') super-blocks.
*/
-static int get_init_pts_sb(struct file_system_type *fs_type, int flags,
+static int init_pts_mount(struct file_system_type *fs_type, int flags,
void *data, struct pts_mount_opts *opts, struct vfsmount *mnt)
{
struct super_block *s;
@@ -397,23 +401,6 @@ static int get_init_pts_sb(struct file_system_type *fs_type, int flags,
return 0;
}
-/*
- * Mount or remount the initial kernel mount of devpts. This type of
- * mount maintains the legacy, single-instance semantics, while the
- * kernel still allows multiple-instances.
- */
-static int init_pts_mount(struct file_system_type *fs_type, int flags,
- void *data, struct pts_mount_opts *opts, struct vfsmount *mnt)
-{
- int err;
-
- err = get_init_pts_sb(fs_type, flags, data, opts, mnt);
- if (err)
- return err;
-
- return err;
-}
-
static int devpts_get_sb(struct file_system_type *fs_type,
int flags, const char *dev_name, void *data, struct vfsmount *mnt)
{
--
1.5.2.5
WARNING: multiple messages have this Message-ID (diff)
From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
hpa@zytor.com, serue@us.ibm.com,
"David C. Hansen" <haveblue@us.ibm.com>,
Containers <containers@lists.osdl.org>,
linux-kernel@vger.kernel.org, sukadev@us.ibm.com
Subject: [RFC][PATCH 4/5] Remove get_init_pts_sb()
Date: Wed, 28 Jan 2009 22:47:20 -0800 [thread overview]
Message-ID: <20090129064720.GE23160@us.ibm.com> (raw)
In-Reply-To: <20090129064259.GA23160@us.ibm.com>
From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Date: Wed, 28 Jan 2009 18:59:28 -0800
Subject: [RFC][PATCH 4/5] Remove get_init_pts_sb()
With mknod_ptmx() moved to devpts_get_sb(), init_pts_mount() becomes
a wrapper around get_init_pts_sb(). Remove get_init_pts_sb() and
fold code into init_pts_mount().
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
---
fs/devpts/inode.c | 25 ++++++-------------------
1 files changed, 6 insertions(+), 19 deletions(-)
diff --git a/fs/devpts/inode.c b/fs/devpts/inode.c
index 97b8e9f..733e8e0 100644
--- a/fs/devpts/inode.c
+++ b/fs/devpts/inode.c
@@ -347,7 +347,11 @@ static int new_pts_mount(struct file_system_type *fs_type, int flags,
}
/*
- * get_init_pts_sb()
+ * init_pts_mount()
+ *
+ * Mount or remount the initial kernel mount of devpts. This type of
+ * mount maintains the legacy, single-instance semantics, while the
+ * kernel still allows multiple-instances.
*
* This interface is needed to support multiple namespace semantics in
* devpts while preserving backward compatibility of the current 'single-
@@ -367,7 +371,7 @@ static int new_pts_mount(struct file_system_type *fs_type, int flags,
* consistently selects the 'single-namespace' superblock even in the
* presence of the private namespace (i.e 'newinstance') super-blocks.
*/
-static int get_init_pts_sb(struct file_system_type *fs_type, int flags,
+static int init_pts_mount(struct file_system_type *fs_type, int flags,
void *data, struct pts_mount_opts *opts, struct vfsmount *mnt)
{
struct super_block *s;
@@ -397,23 +401,6 @@ static int get_init_pts_sb(struct file_system_type *fs_type, int flags,
return 0;
}
-/*
- * Mount or remount the initial kernel mount of devpts. This type of
- * mount maintains the legacy, single-instance semantics, while the
- * kernel still allows multiple-instances.
- */
-static int init_pts_mount(struct file_system_type *fs_type, int flags,
- void *data, struct pts_mount_opts *opts, struct vfsmount *mnt)
-{
- int err;
-
- err = get_init_pts_sb(fs_type, flags, data, opts, mnt);
- if (err)
- return err;
-
- return err;
-}
-
static int devpts_get_sb(struct file_system_type *fs_type,
int flags, const char *dev_name, void *data, struct vfsmount *mnt)
{
--
1.5.2.5
next prev parent reply other threads:[~2009-01-29 6:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-29 6:42 [RFC][PATCH 0/5] Simplify devpts code Sukadev Bhattiprolu
2009-01-29 6:45 ` [RFC][PATCH 1/5] Unroll essentials of do_remount_sb() into devpts Sukadev Bhattiprolu
[not found] ` <20090129064547.GB23160-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-02-01 16:34 ` Christoph Hellwig
2009-02-01 16:34 ` Christoph Hellwig
[not found] ` <20090129064259.GA23160-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-01-29 6:46 ` [RFC][PATCH 2/5] Parse mount options just once and copy them to super block Sukadev Bhattiprolu
2009-01-29 6:46 ` Sukadev Bhattiprolu
[not found] ` <20090129064612.GC23160-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-02-01 16:35 ` Christoph Hellwig
2009-02-01 16:35 ` Christoph Hellwig
2009-01-29 6:46 ` [RFC][PATCH 3/5] Move common mknod_ptmx() calls into caller Sukadev Bhattiprolu
2009-01-29 6:46 ` Sukadev Bhattiprolu
[not found] ` <20090129064643.GD23160-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-02-01 16:36 ` Christoph Hellwig
2009-02-01 16:36 ` Christoph Hellwig
2009-01-29 6:47 ` Sukadev Bhattiprolu [this message]
2009-01-29 6:47 ` [RFC][PATCH 4/5] Remove get_init_pts_sb() Sukadev Bhattiprolu
[not found] ` <20090129064720.GE23160-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-02-01 16:37 ` Christoph Hellwig
2009-02-01 16:37 ` Christoph Hellwig
2009-01-29 6:47 ` [RFC][PATCH 5/5] Merge code for single and multiple-instance mounts Sukadev Bhattiprolu
[not found] ` <20090129064753.GF23160-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-02-01 16:38 ` Christoph Hellwig
2009-02-01 16:38 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090129064720.GE23160@us.ibm.com \
--to=sukadev-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
--cc=alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=haveblue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.