Syntax error in include/asm-mips/gdb-stub.h

Syntax error in include/asm-mips/gdb-stub.h

[Brian Foster]

apologies for not sending a patch — I'm working with a rather
old tree (2.6.21-ish vintage) and am uncertain how useful one
would be — but just collided with a trivial syntax error in
include/asm-mips/gdb-stub.h

        long    lo;
#ifdef CONFIG_CPU_HAS_SMARTMIPS
        long    acx
#endif
        long    cp0_badvaddr;

there is missing semicolon (‘;’) on the centre line (acx).
this mistake is seems to exist in at least the following
(and very probably elsewhere (I'm not a git expert!)):

linux-2.6.25.13
linux-2.6.25.14
linux-2.6.25.15
linux-2.6.25.16
linux-2.6.25.17
linux-2.6.25.18
linux-2.6.25.19
linux-2.6.25.20
linux-2.6.26.1
linux-2.6.26.2
linux-2.6.26.3
linux-2.6.26.4
linux-2.6.26.5
linux-2.6.26.6
linux-2.6.26.7
linux-2.6.26.8

cheers!
	-blf-

-- 
“How many surrealists does it take to   | Brian Foster
 change a lightbulb? Three. One calms   | somewhere in south of France
 the warthog, and two fill the bathtub  |   Stop E$$o (ExxonMobil)!
 with brightly-coloured machine tools.” |      http://www.stopesso.com

Re: Syntax error in include/asm-mips/gdb-stub.h

[Ralf Baechle]

On Thu, Jan 29, 2009 at 02:30:29PM +0100, Brian Foster wrote:

> apologies for not sending a patch — I'm working with a rather
> old tree (2.6.21-ish vintage) and am uncertain how useful one
> would be — but just collided with a trivial syntax error in
> include/asm-mips/gdb-stub.h
> 
>         long    lo;
> #ifdef CONFIG_CPU_HAS_SMARTMIPS
>         long    acx
> #endif
>         long    cp0_badvaddr;
> 
> there is missing semicolon (‘;’) on the centre line (acx).
> this mistake is seems to exist in at least the following
> (and very probably elsewhere (I'm not a git expert!)):

Or in simpler words, in all -stable branches upto and including 2.6.26.

  Ralf

Re: Syntax error in include/asm-mips/gdb-stub.h

[Brian Foster]

On Thursday 29 January 2009 19:18:32 Ralf Baechle wrote:
> On Thu, Jan 29, 2009 at 02:30:29PM +0100, Brian Foster wrote:
> > apologies for not sending a patch [... fixing] missing semicolon (‘;’)
> > this mistake is seems to exist in at least the following  [ ... ]
> 
> Or in simpler words, in all -stable branches upto and including 2.6.26.

 yep.  thanks, that's a better way of putting it.  also thanks
 for fixing the issue.  again, apologies for sending a patch.
cheers!
	-blf-

-- 
“How many surrealists does it take to   | Brian Foster
 change a lightbulb? Three. One calms   | somewhere in south of France
 the warthog, and two fill the bathtub  |   Stop E$$o (ExxonMobil)!
 with brightly-coloured machine tools.” |      http://www.stopesso.com