From: Matthias Kaehlcke <matthias@kaehlcke.net>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: akpm@linux-foundation.org, linux-mtd@lists.infradead.org,
David.Woodhouse@intel.com, vapier.adi@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [BUG] physmap_flash_probe() frees memory still in use
Date: Fri, 30 Jan 2009 17:44:12 +0100 [thread overview]
Message-ID: <20090130164412.GC16711@traven> (raw)
In-Reply-To: <20090131.005250.95064457.anemo@mba.ocn.ne.jp>
El Sat, Jan 31, 2009 at 12:52:50AM +0900 Atsushi Nemoto ha dit:
> On Fri, 30 Jan 2009 14:43:18 +0100, Matthias Kaehlcke <matthias@kaehlcke.net> wrote:
> > as i reported earlier in this month
> > (http://lkml.org/lkml/2009/1/12/141) MTD partition names are screwed
> > up in 2.6.29-rcX.
> >
> > commit 176bf2e0f10ecf1d20a97db3bd5bb2e6ba0b5668 deals with a memory
> > leak and frees the pointer array of mtd_partition after the call to
> > add_mtd_partitions(). the problem is that mtd_table[x]->name still
> > points to the freed memory.
>
> Oh Yes, I had missed that point. And looking at physmap driver again,
> I found that del_mtd_partition() and del_mtd_device() are abused.
> Though these APIs are robust enough, deleting right things in right
> order would be better.
>
> Could you test this patch? I cannot test it until Monday.
looks good!
Tested-By: Matthias Kaehlcke <matthias@kaehlcke.net>
--
Matthias Kaehlcke
Embedded Linux Engineer
Barcelona
If you don't know where you are going,
you will probably end up somewhere else
(Laurence J. Peter)
.''`.
using free software / Debian GNU/Linux | http://debian.org : :' :
`. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `-
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Kaehlcke <matthias@kaehlcke.net>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: akpm@linux-foundation.org, David.Woodhouse@intel.com,
vapier.adi@gmail.com, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [BUG] physmap_flash_probe() frees memory still in use
Date: Fri, 30 Jan 2009 17:44:12 +0100 [thread overview]
Message-ID: <20090130164412.GC16711@traven> (raw)
In-Reply-To: <20090131.005250.95064457.anemo@mba.ocn.ne.jp>
El Sat, Jan 31, 2009 at 12:52:50AM +0900 Atsushi Nemoto ha dit:
> On Fri, 30 Jan 2009 14:43:18 +0100, Matthias Kaehlcke <matthias@kaehlcke.net> wrote:
> > as i reported earlier in this month
> > (http://lkml.org/lkml/2009/1/12/141) MTD partition names are screwed
> > up in 2.6.29-rcX.
> >
> > commit 176bf2e0f10ecf1d20a97db3bd5bb2e6ba0b5668 deals with a memory
> > leak and frees the pointer array of mtd_partition after the call to
> > add_mtd_partitions(). the problem is that mtd_table[x]->name still
> > points to the freed memory.
>
> Oh Yes, I had missed that point. And looking at physmap driver again,
> I found that del_mtd_partition() and del_mtd_device() are abused.
> Though these APIs are robust enough, deleting right things in right
> order would be better.
>
> Could you test this patch? I cannot test it until Monday.
looks good!
Tested-By: Matthias Kaehlcke <matthias@kaehlcke.net>
--
Matthias Kaehlcke
Embedded Linux Engineer
Barcelona
If you don't know where you are going,
you will probably end up somewhere else
(Laurence J. Peter)
.''`.
using free software / Debian GNU/Linux | http://debian.org : :' :
`. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `-
next prev parent reply other threads:[~2009-01-30 16:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-30 13:43 [BUG] physmap_flash_probe() frees memory still in use Matthias Kaehlcke
2009-01-30 13:43 ` Matthias Kaehlcke
2009-01-30 15:52 ` Atsushi Nemoto
2009-01-30 15:52 ` Atsushi Nemoto
2009-01-30 16:44 ` Matthias Kaehlcke [this message]
2009-01-30 16:44 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090130164412.GC16711@traven \
--to=matthias@kaehlcke.net \
--cc=David.Woodhouse@intel.com \
--cc=akpm@linux-foundation.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.