From: Aurelien Jarno <aurelien@aurel32.net>
To: Takashi YOSHII <takasi-y@ops.dti.ne.jp>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] take2. SH: Fix struct target_stat64 for 64bit host
Date: Fri, 30 Jan 2009 20:48:21 +0100 [thread overview]
Message-ID: <20090130194821.GA19283@hall.aurel32.net> (raw)
In-Reply-To: <200810261537.m9QFbd4n026386@smtp12.dti.ne.jp>
On Mon, Oct 27, 2008 at 12:37:39AM +0900, takasi-y@ops.dti.ne.jp wrote:
> I send fixed one, because I found (perhaps) I should send fixed patch with
> signed-off line to be committed to the repository....
>
> This one simply add packed attribute to the struct, as michael pointed out.
>
> Signed-off-by: Takashi YOSHII <takasi-y@ops.dti.ne.jp>
Thanks, applied.
> ---
> linux-user/syscall_defs.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h
> index 5a58010..8131905 100644
> --- a/linux-user/syscall_defs.h
> +++ b/linux-user/syscall_defs.h
> @@ -1475,7 +1475,7 @@ struct target_stat {
> /* This matches struct stat64 in glibc2.1, hence the absolutely
> * insane amounts of padding around dev_t's.
> */
> -struct target_stat64 {
> +struct __attribute__((__packed__)) target_stat64 {
> unsigned long long st_dev;
> unsigned char __pad0[4];
>
> --
> 1.5.4.3
>
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
prev parent reply other threads:[~2009-01-30 19:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-15 17:49 [Qemu-devel] sh4 linux user emulation on an x86_64 system michael
2008-10-15 18:46 ` Vince Weaver
2008-10-15 20:53 ` michael
2008-10-20 11:31 ` [Qemu-devel] [PATCH] SH: Fix struct target_stat64 for 64bit host takasi-y
2008-10-20 13:52 ` [Qemu-devel] " michael
2008-10-20 17:18 ` [Qemu-devel] " michael
2008-10-20 17:35 ` michael
2008-10-21 3:48 ` [Qemu-devel] " takasi-y
2008-10-26 15:37 ` [Qemu-devel] [PATCH] take2. " takasi-y
2009-01-30 19:48 ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090130194821.GA19283@hall.aurel32.net \
--to=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
--cc=takasi-y@ops.dti.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.